human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Add [DO NOT REPLY] to the name for the accounts email.

Open cielf opened this issue 1 year ago • 11 comments

Summary

Add [DO NOT REPLY] to the name for the accounts email

Why?

Just another prompt so that fewer partners will send us queries that should go to their bank

Details

[email protected]

Criteria for completion

  • [ ] The account email name has [DO NOT REPLY] appended to it

cielf avatar Jul 14 '24 15:07 cielf

I would like to take this issue.

Trevor-Robinson avatar Jul 19 '24 21:07 Trevor-Robinson

It is yours.

cielf avatar Jul 19 '24 21:07 cielf

I was taking a look at this issue today and had a question:

Most mailers have a default from that is set to "Please do not reply to this email as this mail box is not monitored — Human Essentials [email protected]". The mailers that show up from [email protected] are the only ones that don't have this default from set. Should the default from in those mailers just be set to match or should it specifically be set to "[DO NOT REPLY][email protected]"?

Or am I going about this wrong and the goal is to change the actual accounts address at the Devise configuration level, instead of just overriding the from field when the emails go out?

Trevor-Robinson avatar Jul 22 '24 17:07 Trevor-Robinson

@dorner - Can you address the above question, please? Thank you!

cielf avatar Jul 22 '24 18:07 cielf

We definitely don't need to override the actual account. Just the from. And yes, ideally it should match everywhere.

@cielf up to you if you prefer the DO NOT REPLY prefix or the longer one. I like the first one, myself :)

dorner avatar Jul 26 '24 19:07 dorner

DO NOT REPLY seems fine. The longer one would be a lie for [email protected].

cielf avatar Jul 27 '24 02:07 cielf

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Aug 28 '24 00:08 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Sep 04 '24 00:09 github-actions[bot]

Would it be possible for me to pick this back up? I was away for a bit.

Trevor-Robinson avatar Sep 17 '24 22:09 Trevor-Robinson

Sure!

cielf avatar Sep 19 '24 16:09 cielf

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Oct 20 '24 00:10 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Oct 28 '24 00:10 github-actions[bot]

Hi @cielf , I’d like to work on this! I have linked a WIP draft PR with some code changes and description while I was looking into this issue.

If possible, could someone please review the PR to ensure I’m heading in the right direction?

Sukhpreet-s avatar Nov 26 '24 07:11 Sukhpreet-s

It looks to me as if you are headed in the right direction.

cielf avatar Nov 26 '24 12:11 cielf