human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

[BUG] Issue with selecting children for request who are not currently active

Open cielf opened this issue 1 year ago • 0 comments

Summary

If you select a child to be in a request, that child's items should be included in the request, whether or not the child is currently designated active.

Why?

We assume the partner knows that the child is receiving items this request, whether or not they are really considered to be active. Perhaps it's a one-off for reasons we don't know, but we wouldn't expect them to be defaulted to getting items next request.

Details

To see this, login in as [email protected], and do a child request without changing the selection on any of the children. Then do the same request, but also toggling one of the children who are not currently selected to receive items.
Check the levels on the items that child is slotted to received. Currently, those two requests would have the same amounts. They shouldn't be.

Criteria for completion

  • [ ] Requests for all selected children (both active and inactive) are included in the final request
  • [ ] Tests to demonstrate that is true.

cielf avatar Jul 14 '24 15:07 cielf