human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Handling old/stale account requests

Open cielf opened this issue 1 year ago • 2 comments

Summary

Provide the ability to cleanup old account requests without sending out rejections

Why

The amount of unconfirmed have gotten a little out of hand, plus we have a (currently ongoing) problem where we have had to add some organizations by hand. #Details

Let's add a new status that will hold this concept of we aren't going on with this for some reason that isn't going to make us send a note out to the user. Let's call it "admin_closed"

"Admin Closed" requests should be in the closed scope (for display purposes)

Provide a button "Close (Admin)" to move a request to the status on each account request that is in Started or User Confirmed status. Allow provision of an optional reason.

This status change should not generate any emails.

Criteria for completion

  • [ ] Addition of administrative close functionality as detailed above
  • [ ] tests to support this functionality

cielf avatar Jul 14 '24 14:07 cielf

Hi @cielf So I will take this, Can you give me more details about where exactly are the account requests to be rejected? I want to be sure. Thx

manuel1280 avatar Aug 27 '24 16:08 manuel1280

sSgn in as [email protected]. Click on Account Requests. I don't think there are any Account Requests in the seed, unfortunately.

So -- to set up an account request, you would (while not logged in) go to the home page and click "register your bank here for free". IIRC there is a step where you confirm that you are a bank rather than a partner, then fill in the form and submit. This will generate an email, which should appear in your browser in a couple of minutes.

At this point the user is an unconfirmed user, and should appear in the Account Requests as such. There is also a link in the email to confirm that you are real. That changes the status on the account request.

I hope that's enough to get you started!

cielf avatar Aug 27 '24 17:08 cielf

Hi @cielf I already have the branch, but I don't know how to create the PR, when I try to push the branch I get this error 'fatal: Authentication failed for 'https://github.com/rubyforgood/human-essentials.git/'', I cloned the project by ssh. can you guide me please

manuel1280 avatar Aug 30 '24 18:08 manuel1280

Hi @cielf I already have the branch, but I don't know how to create the PR, when I try to push the branch I get this error 'fatal: Authentication failed for 'https://github.com/rubyforgood/human-essentials.git/'', I cloned the project by ssh. can you guide me please

Nevermind, I was doing wrong. The PR is done, I hope everything is ok :) https://github.com/rubyforgood/human-essentials/pull/4622

manuel1280 avatar Aug 30 '24 21:08 manuel1280