human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Super admin should be able to add different kinds of users

Open cielf opened this issue 1 year ago • 6 comments

Summary

Superadmins should be able to add any type of user. Right now, they have to add a organization user, and then can add roles.

Why change

We don't really ever want to add partners directly, but new user types (e.g. the proposed NDBN type) will not have an organization to belong to. Super admins should be able to add super admins as well -- right now we have to add them through the back end.

Details

So what do we want to do

Remove the "organization" on add user.
Add "Role" and "Resource" fields that are completed to determine the role the new user has.

The available selection for the "Resource" field should be determined by the Role -- if org_user or org_admin, the resources available would be the Organizations -- if partner, the resources available would be the Partners -- no resource available for SuperAdmin role.

Name, email, Role fields are mandatory. Resource is mandatory iff role has a resource (i.e. org_admin, org_user or partner)

Criteria for completion

  • [ ] Superadmin can directly add users with the different roles described above
  • [ ] tests to demonstrate this functionality

cielf avatar Jul 07 '24 15:07 cielf

@cielf may I have this issue?

AweysAhmed avatar Jul 09 '24 01:07 AweysAhmed

Go for it!

cielf avatar Jul 09 '24 01:07 cielf

When testing this out, check the case mentioned in issue #4532.

cielf avatar Jul 21 '24 15:07 cielf

When testing this out, check the case mentioned in issue #4532.

Thanks. I'll look into that.

AweysAhmed avatar Jul 24 '24 16:07 AweysAhmed

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Aug 24 '24 00:08 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Aug 31 '24 00:08 github-actions[bot]

May I work on this one?

Benjamin-Couey avatar Feb 18 '25 16:02 Benjamin-Couey

It makes sense to pair it with #4819 which you're already working on, so ok.

cielf avatar Feb 18 '25 18:02 cielf

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Mar 21 '25 00:03 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Mar 28 '25 00:03 github-actions[bot]

This has a PR in the final throes of review. It is not in a help-wanted state.

cielf avatar Mar 28 '25 00:03 cielf