human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard
verified publisher icon rubyforgood

4438 - Button Remain Activated After Selecting the Storage

Open Naraveni opened this issue 1 year ago • 1 comments

Resolves #4438

Description

Add Item button was getting de-activated if storage location is selected after first attempt of submitting form without selecting anything.

Include anything else we should know about. -->

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Naraveni avatar Jun 29 '24 16:06 Naraveni

I have added test in distrbution and transfers system specs files as the changes I made are in js file which is related to distributions and transfers as the file name suggests.

Naraveni avatar Jul 01 '24 02:07 Naraveni

Functionality checks out. Over to @dorner for a technical pass

cielf avatar Jul 02 '24 17:07 cielf

And also the error message in transfers creation page was coming wrong ias the
tags were not treated as html and included in normal text. I though of using html_safe but it is a potential risk, So I Simple went with (, ) separator which we are doing in lot of place in our code base

Naraveni avatar Jul 13 '24 13:07 Naraveni

@Naraveni: Your PR 4438 - Button Remain Activated After Selecting the Storage is part of today's Human Essentials production release: 2024.07.21. Thank you very much for your contribution!

github-actions[bot] avatar Jul 21 '24 14:07 github-actions[bot]