human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Fix #4172 donation validation display error

Open jimmyli97 opened this issue 8 months ago • 0 comments

Resolves #4172

Description

  • donation items are now correctly displayed after invalid edit would bring inventory to below distributed amount
  • rspec request test for above

Alternatives considered

  • in the rspec, not sure how specific to be in the error message test, I added tests for both using Events and not using Events
  • in the rspec, not sure if it's better to use factorybot create(:distribution) instead of PUT

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • manual testing
  • bundle exec rake

Screenshots

image

jimmyli97 avatar Jun 28 '24 00:06 jimmyli97