human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

[PACKS] # 9 Distribution printout for banks includes custom request units, if applicable

Open cielf opened this issue 1 year ago • 2 comments

Summary

Distribution printout for banks includes custom request units, if applicable.

Why

This is step #9 of adding the ability to specify "packs" versus "individual" for requests

Details

If any of the requested items have units selected Add custom units to the requested amounts. This may require some adjustment in column widths

Hint

app/pdfs/distribution_pdf.rb

Visual aid

Image

N.B.

All of the changes for PACKS must be implemented behind a flipper flag "enable_packs" 1/ Flipper works by enabling or disabling a tag (for the PACKS issues, that is enable_packs) 2/ Here is a code snippet illustrating how to use it in your code, with enable_packs as the example tag: if Flipper.enabled?(:enable_packs) // do the thing we are guarding with the tag end 3/ How to check out if it works manually (with the example tag: enable_packs ): You have to enable the flipper tag on your localhost (note - the tag is stored in your db, so if you reset your db you have to do it again)

localhost:3000/flipper

userid: admin password: password Sign In

Click: Add feature enable_packs Click: Add feature

Click: Fully enable

To set it back (to check that your nifty changes haven’t broken anything when the flag is off) Sign in as above: click on “enable_packs” click “Delete” type enable_packs in the “Are you sure” dialog and click ok

Criteria for completion

  • [ ] functionality as described above
  • [ ] tests that support the functionality as described above

Background

The following sections have been identified as required for the PACKS implementation. These should be implemented in numerical order.

Image

cielf avatar May 30 '24 18:05 cielf

I believe this is blocked by #4403 and #4540

jimmyli97 avatar Jul 25 '24 16:07 jimmyli97

I believe we set up some data in the seed so that it could be done, but I certainly agree that it will be easier to work on with #4403 in place. I don't think it's blocked by #4540.

cielf avatar Jul 25 '24 17:07 cielf

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Sep 25 '24 00:09 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Oct 02 '24 00:10 github-actions[bot]