human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

[PACKS] # 6 Add custom request units to partner's request list

Open cielf opened this issue 1 year ago • 7 comments

Summary

Add custom request units to partner's request list .

Why

This is step #6 of adding the ability to specify "packs" versus "individual" for requests

Details

Include the units in the requested items lists on the partner dashboard and in the request history.
format: quantity unit -- description e.g. 10 packs -- Kid's Size 3 But if there are no custom units for that item or the 'default unit' is chosen, then merely eliminate the unit 10 -- Strollers

Image

N.B.

All of the changes for PACKS must be implemented behind a flipper flag "enable_packs"

Criteria for completion

  • [ ] functionality as described above
  • [ ] tests that support the functionality as described above

Background

The following sections have been identified as required for the PACKS implementation. These should be implemented in numerical order.

Image

cielf avatar May 30 '24 18:05 cielf

Myself and @FelipeGithub24 will tackle this!

awwaiid avatar May 31 '24 14:05 awwaiid

Awesome...!

FelipeGithub24 avatar May 31 '24 14:05 FelipeGithub24

@cielf problem -- there is a "number of items requested" column, do you know what we should do with that?

awwaiid avatar May 31 '24 14:05 awwaiid

Ah -- I see ... I would still just count up the numbers .

cielf avatar May 31 '24 14:05 cielf

Because the partner is thinking of the pack as an item, yes?

cielf avatar May 31 '24 14:05 cielf

It's not perfect, but anything else we could do would be very complicated. I'm not sure what people use that column for. Let's try that and if people are confused by it we will do something else [We can confirm at the next stakeholder meeting.]

cielf avatar May 31 '24 15:05 cielf

PR merged over at https://github.com/rubyforgood/human-essentials/pull/4416, leaving this open while we do some review!

awwaiid avatar Jun 02 '24 11:06 awwaiid

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Jul 03 '24 00:07 github-actions[bot]

Closing -- will do end-to-end QA in https://github.com/rubyforgood/human-essentials/issues/4501

Thank you!

awwaiid avatar Jul 07 '24 14:07 awwaiid