human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

[PACKS] # 1 Add custom request units at organizational level

Open cielf opened this issue 1 year ago • 1 comments

Summary

Add custom request units at organizational level (requires PACKS #0 completion first)

Why

This is step #1 of adding the ability to specify "packs" versus "units" for requests

Details

Add custom request units used to the organization, on both edit and show.

Prompts, fields and buttons for edit:

Custom request units used (please use singular form -- e.g. pack, not packs) :
Custom request unit : [text field] [Remove]
[+Add another unit]

For show:

Custom request units used:
list the units, one to a line none, if no units selected

Rules: Can not be duplicated within the organization Can not be removed if any items are using the unit.

These will be used as the basis for allowing customized units on specific items.

N.B.

All of the UI changes for PACKS must be implemented behind a flipper flag "enable_packs"

Screen hint for organization edit placement

Image

Screen hint for organization view

Image

Note from dev discussion

It's not problematic to remove a unit that has previously been active for item (and used in requests). The restriction in the Rules section above is only for units that are currently active on an item.

Criteria for completion

  • [ ] functionality as described above
  • [ ] tests that support the functionality as described above

Background

The following sections have been identified as required for the PACKS implementation. These should be implemented in numerical order. The pre-work [PACKS #0] must be completed first.

Image

cielf avatar May 30 '24 18:05 cielf

I can take this one 👍

Eccatoe avatar May 31 '24 14:05 Eccatoe

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Jul 03 '24 00:07 github-actions[bot]

Merged!

awwaiid avatar Jul 21 '24 12:07 awwaiid