human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Published 20 hours ago • verified publisher icon rubyforgood

refactor: remove reliance on preseeded data (requests 2)

Open elasticspoon opened this issue 9 months ago • 2 comments

Related to https://github.com/rubyforgood/human-essentials/issues/4199

Remaining request tests.

Type of change

  • Refactor

How Has This Been Tested?

Passes current suite

elasticspoon avatar May 04 '24 04:05 elasticspoon

@elasticspoon is this ready for review?

dorner avatar May 05 '24 14:05 dorner

@elasticspoon is this ready for review?

Not quite. There is some weird order dependent issue that goes away when the hard models pr is merged. So PR depends on that one.

I am also now firmly on team remove base items.

elasticspoon avatar May 05 '24 14:05 elasticspoon

@elasticspoon: Your PR refactor: remove reliance on preseeded data (requests 2) is part of today's Human Essentials production release: 2024.05.12. Thank you very much for your contribution!

github-actions[bot] avatar May 12 '24 16:05 github-actions[bot]