human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Published 20 hours ago • verified publisher icon rubyforgood

4175 add request type flag

Open nathangthomas opened this issue 10 months ago • 8 comments

Resolves #4175

Description

Adds a request type flag to index and show pages as well as to the downloadable document so that banks can better see which type of request is being made.

Type of change

  • New feature (non-breaking change which adds functionality)

This can be manually tested by logging in as a bank user.

  Organization Admin
     Email: [email protected]
  Password: password!

  User
  Email: [email protected]
  Password: password!

Screenshots

Screenshot 2024-04-02 at 8 41 09 AM Screenshot 2024-04-02 at 8 41 21 AM

Requests-2024-04-02.csv

nathangthomas avatar Apr 12 '24 17:04 nathangthomas

I will try to get to this. I am currently on a tight schedule.

nathangthomas avatar May 07 '24 14:05 nathangthomas

Understood. The rest still needs @dorner 's technical ok -- it's not crucial for it to get in this week.

cielf avatar May 07 '24 16:05 cielf

Same effect for individual and child request. (Not at all surprised by that)

cielf avatar May 16 '24 20:05 cielf

Well that is embarrassing. I'll take a look at it this afternoon.

nathangthomas avatar May 17 '24 13:05 nathangthomas

Seems I either forgot to add or removed request_type from the initializers. I have replaced them and tested locally. Everything should work as expected now.

nathangthomas avatar May 17 '24 20:05 nathangthomas

There's an issue with setup that's currently blocking me doing functional reviews -- just managing your expectations as to turnaround time.

cielf avatar May 21 '24 22:05 cielf

Had a question... also, lint is failing now.

dorner avatar May 24 '24 19:05 dorner

@nathangthomas looks like this is almost ready to go - can you finish it up?

dorner avatar Aug 16 '24 19:08 dorner