human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Change style of messages regarding inactive items

Open cielf opened this issue 1 year ago • 16 comments

Summary

Colour change for messages regarding inactive items

Why

We have been asked to make warning messages less scary. Also, these are informational more than warning

Details

Make these particular messages plain text.

This is a good first items level of difficulty, but it takes a lot of going through things to demonstrate.

how to see all the messages we are talking about

  • set up a new distribution (Distributions | New Distribution) , a new donation (Donation |New Donation), and a new purchase (Purchases | New Purchase) that are all using a particular item (e.g. Adult Briefs L/XL)
  • then go into Inventory | Inventory Adjustments
  • Enter new Inventory Adjustments to take the levels for that item for each storage location down to 0
  • Go to Inventory|Items & Inventory
  • Deactivate the item
  • Go to Distiributions
    • you should see a "Has Inactive Items" message. The style of this message should be changed
    • click View on that item, and scroll to the bottom
      • you should see a message indicating why you can't correct this. The style of this message should be changed
  • Go to Donations
  • Click view on the donation you entered and scroll to the bottom
      • you should see a message indicating why you can't correct this. The style of this message should be changed
  • Go to Purchases
    • Click view on the purchase you entered and scroll to the bottom
      • you should see a message indicating why you can't correct this. The style of this message should be changed

Criteria for completion

  • [ ]styles of the indicated messages are changed
  • [ ]please provide screenshots with your PR

cielf avatar Mar 31 '24 15:03 cielf

@cielf may I work on this issue?

AweysAhmed avatar Apr 05 '24 17:04 AweysAhmed

It's yours!

dorner avatar Apr 05 '24 17:04 dorner

It's yours!

Thank you!

AweysAhmed avatar Apr 05 '24 17:04 AweysAhmed

@dorner @cielf just wanted to provide an update. I'll be working on this week and weekend.

AweysAhmed avatar Apr 23 '24 13:04 AweysAhmed

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar May 24 '24 00:05 github-actions[bot]

Sorry for the delay. Work and life got busy but if I don't start this weekend, I will remove myself from this issue.

AweysAhmed avatar May 24 '24 12:05 AweysAhmed

I am working on this. I have found an issue that I will bring up in slack.

AweysAhmed avatar May 27 '24 23:05 AweysAhmed

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Jun 04 '24 00:06 github-actions[bot]

@cielf @dorner I started working on this to recreate the issue but I ran into a few issues trying to do that. May I still have this?

AweysAhmed avatar Jun 05 '24 23:06 AweysAhmed

Reassigning it to you.

cielf avatar Jun 05 '24 23:06 cielf

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Jun 13 '24 00:06 github-actions[bot]

Reassigning it to you.

I have a PR that I’m working on for this issue. I didn’t think it would unassign me.

I assume if I push up changes it won’t be labeled inactive.

May I have this again?

AweysAhmed avatar Jun 13 '24 00:06 AweysAhmed

Alas, it's not that smart. I've reassigned you.

cielf avatar Jun 13 '24 12:06 cielf

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Jun 21 '24 00:06 github-actions[bot]

@cielf @dorner I have a PR upready for review. Do I need to have this issue assigned back to me?

AweysAhmed avatar Jun 23 '24 20:06 AweysAhmed

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Jul 01 '24 00:07 github-actions[bot]

This has a PR in review.

cielf avatar Jul 02 '24 17:07 cielf