human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Add a flag that is the type of request.

Open cielf opened this issue 11 months ago • 14 comments

Summary

Add a request type flag that will be visible to the banks

Why

The banks don't know which request types their partners are using. Knowing will help them supporting their partners

Details

Add a flag to request that will be set according to whether the request is a quantity request, a by-individuals request or a child-based request. Show this to the bank on their request view, and in the request export.

This would enable the banks to see, after a couple of cycles, whether any of their partners are using each request type, and be able to simplify the options available to their partners based on that information.

Criteria for completion

  • [ ] addition of flag to request model
  • [ ] setting the flag depending on the kind of request
  • [ ] displaying the flag on the bank's view of the request
  • [ ] displaying the flag in the request export.
  • [ ] tests to support the above functionality

cielf avatar Mar 10 '24 14:03 cielf

@cielf I can take this ticket.

nathangthomas avatar Mar 15 '24 15:03 nathangthomas

Go for it!

cielf avatar Mar 15 '24 16:03 cielf

Would it be beneficial for there to be a default request type? If so which one?

  1. quantity
  2. by-individuals
  3. child-based

EDIT Actually... After digging into this a bit more it doesn't seem like there will be a need for a default request as type will be automatically set each time a new request is made.

nathangthomas avatar Mar 15 '24 19:03 nathangthomas

That's right -- the type will be known before the request is created.

cielf avatar Mar 16 '24 00:03 cielf

@cielf are there any specific colors you would like each flag to be? I have included some screenshots of the request index and show pages as well as the export.

nathangthomas avatar Mar 19 '24 17:03 nathangthomas

Screenshot 2024-03-19 at 11 45 29 AM

nathangthomas avatar Mar 19 '24 17:03 nathangthomas

Screenshot 2024-03-19 at 11 51 34 AM

nathangthomas avatar Mar 19 '24 17:03 nathangthomas

Screenshot 2024-03-19 at 12 34 22 PM

nathangthomas avatar Mar 19 '24 18:03 nathangthomas

Lets just have them all be normal text. They are just informational, and otherwise the users might think they are buttons.

I would actually just call them quantity, individual and child as well (should have noticed that earlier).

cielf avatar Mar 19 '24 23:03 cielf

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar May 03 '24 00:05 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar May 10 '24 00:05 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar May 18 '24 00:05 github-actions[bot]

This is in the final throes of review.

cielf avatar May 18 '24 12:05 cielf

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar May 26 '24 00:05 github-actions[bot]