human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

[UI wart]: Distribution schedule copy-to-clipboard button takes half the vertical view

Open scooter-dangle opened this issue 1 year ago • 16 comments

Summary

The button on the distribution schedule for copying the calendar url is huge. It should be a normal button size.

Why

It's something that the user does once and once only, so it shouldn't be taking up so much space

Details

Current Behavior

Distribution schedule on staging showing copy-calendar-url-to-clipboard button taking half the vertical space and the visible calendar truncating the week of the 29th for the current month of January

Replicable on staging: Distribution schedule has copy-calendar-url-to-clipboard button taking half the vertical space and the visible calendar is truncating the view of the current month (January), forcing user to scroll down in the calendar view to see the week of the 29th.

Expected Behavior

Copy-calendar-url-to-clipboard button should be button-sized and, with sufficient screen space, shouldn't force the month view to be truncated.

Steps To Reproduce

  1. in staging
  2. navigate to https://staging.humanessentials.app/diaper_bank/distributions/schedule

Criteria for Completion

  • [ ] button is a normal size.
  • [ ] Provide a before/after screenshot with your PR, please.

scooter-dangle avatar Jan 07 '24 16:01 scooter-dangle

I would like to take a crack at this issue.

julianm1138 avatar Jan 08 '24 03:01 julianm1138

I would like to take a crack at this issue.

It's yours!

scooter-dangle avatar Jan 08 '24 13:01 scooter-dangle

When I try to access the link to duplicate the issue by signing in with my google account, I get this error:

image

When I try to sign up I get this page:

image

I just want to make sure I'm going about accessing the page correctly so I can fix the button.

julianm1138 avatar Jan 08 '24 19:01 julianm1138

If you're running locally (via seeds), you can log in with the credentials listed in the README.

dorner avatar Jan 08 '24 19:01 dorner

Apologies, but I am inexperienced with open source and I've just been trying to get the environment set up. However, I did login with the sample users for staging and I didn't see any truncating issues with the calendar. image Did somebody already fix the issue?

julianm1138 avatar Jan 17 '24 03:01 julianm1138

@julianm1138 I just looked at it on staging, and initially I thought it was working too, but if I make my browser full screen, it gets larger.

cielf avatar Jan 17 '24 13:01 cielf

@cielf which login credentials did you use? I used User Email: [email protected] for bank users and full screen is still not truncating the calendar for me.

julianm1138 avatar Jan 17 '24 16:01 julianm1138

I am getting the big button as user_1 on staging. Are you using Chrome? (Chrome is our sole official supported browser)

cielf avatar Jan 17 '24 22:01 cielf

Yup! I always use Chrome, so it's quite odd. I just tried it again to be sure and the button is still thin like I screenshotted it. But hey, if it's too big in the main codebase I'm still down to fix it, I'm just trying to figure out how to get connected to the database. If somebody would like to hop on a discord call with me or something to help get me started I would be extremely grateful because I want to contribute but to be honest I'm sort of stuck at recreating the environment on my machine and getting everything in front of me.

julianm1138 avatar Jan 18 '24 02:01 julianm1138

Are you available Sunday mornings? We have "office hours" at 11am.

cielf avatar Jan 18 '24 04:01 cielf

Is it 11 am EST? Yes that sounds cool.

julianm1138 avatar Jan 18 '24 17:01 julianm1138

It is.

cielf avatar Jan 18 '24 18:01 cielf

And where's it being held, somewhere on slack, and is there a specific voice channel or something like that?

julianm1138 avatar Jan 18 '24 19:01 julianm1138

And where's it being held, somewhere on slack, and is there a specific voice channel or something like that?

We post the link to the Ruby for Good human-essentials Slack channel.

scooter-dangle avatar Jan 18 '24 20:01 scooter-dangle

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Feb 18 '24 00:02 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Feb 25 '24 00:02 github-actions[bot]

I am not a FE expert, added couple of css to fix it. Please review.

kannans5 avatar Mar 01 '24 17:03 kannans5