Clean up unused base item fields

[cielf]

Summary

Some of the fields on base item are not used. Delete them.

Why

Avoiding future developer confusion

Details

Look at the super user base item form and the BaseItem model. They don't match. Check the fields that are not represented -- if they are not used in the system at all, then they should be deleted.

Criteria for completion

[] migration to delete the fields [] all tests pass after migration

[dorner]

@cielf so it looks like there are 2 fields that are null for everything (size and barcode_count). The problem is category, which is a string. It looks like there's no way to edit it, and new items don't have it (instead they use item_category_id). The problem is that for reporting, we're using this category field to indicate if an item is disposable or not. We definitely can't remove it now, but I think it exposes another issue, which is that whether an item should be considered "disposable", "cloth", or "adult incontinence" items should not be based on this field in base_items. (For one thing, orgs can create as many items as they like, and we're just not tracking them using this approach.)

I can remove those 2 fields for this issue and open another one for the category problem, or try to tackle it in here. Thoughts?

[cielf]

@dorner I think we clean up those two fields, but put a proto-issue in the backlog for the category problem, under "needs developer discussion". We do need a reliable way to determine whether an item is disposable, etc. Whether that is this (and we add setting the field for superusers) or putting some flags on the items or something else is TBD. I'm not sure I see the problem with using the base item field. Otherwise, what is base item for at all?

Which is a fine question in itself.

I have added the proto-issue.

[github-actions[bot]]

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

[github-actions[bot]]

Automatically unassigned after 7 days of inactivity.

[github-actions[bot]]

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

[cielf]

This is waiting for some testing.

[github-actions[bot]]

Automatically unassigned after 7 days of inactivity.