human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Cleanup on admin_ paths

Open cielf opened this issue 2 years ago • 1 comments

Summary

Admin paths currently require a organization_id, which is the short_name. Unless actually dealing with an organization, they shouldn't. Also address the mismatch between the parameter name and what is used.

Why fix

Confusion. Current solution is kludgey (having to hackishly send a faux short name to get to admin things)

Details

Admin paths currently require a organization_id, which is the short_name.
Unless actually dealing with an organization, they shouldn't.
Also address the mismatch between the parameter name (organization_id) and what is used (short_name).

Notes

Origin of issue

See discussion on https://github.com/rubyforgood/human-essentials/pull/3664

Criteria for completion

  • [ ] The admin paths no longer require an organization id when they aren't dealing with an org
  • [ ] The parameter name used to identify organizations and what is passed match
  • [ ] It doesn't break anything else -- ALL tests work

cielf avatar Dec 24 '23 15:12 cielf

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Feb 05 '24 00:02 github-actions[bot]

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Mar 11 '24 00:03 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Mar 18 '24 00:03 github-actions[bot]