human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Include diapers in kits in NDBN report values that are based on 'number of diapers'.

Open cielf opened this issue 2 years ago • 4 comments

Summary

The values in the NDBN report that are for number of disposale diapers distributed, and other associated values do not include disposable diapers distributed in kits. They should.

Why

Why not?

Details

Look at the services/reports/acquisition_report_service and services/reports/children_served_report_service Assume 1 kit per child for the children served part

Criteria for completion

[ ] number of disposable diapers distributed on NDBN report includes disposable diapers in kits [ ] children served with disposable diapers on NDBN report takes into account disposable diapers in kits [ ] tests demonstrating the above changes.

cielf avatar Dec 24 '23 15:12 cielf

I'd like to take this on :)

jadekstewart3 avatar Dec 29 '23 18:12 jadekstewart3

Please do.

cielf avatar Dec 30 '23 15:12 cielf

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Jan 30 '24 00:01 github-actions[bot]

Sill being worked on at this point - we had a delay to settle on terminology

cielf avatar Jan 31 '24 16:01 cielf

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Mar 03 '24 00:03 github-actions[bot]

@jadekstewart3 -- you were still working on this as of Feb 22 -- checking in -- do you need someone to step in on the gnarly SQL?

cielf avatar Mar 03 '24 22:03 cielf

@cielf I think I do, I'm having a heck of a time getting it :/

jadekstewart3 avatar Mar 04 '24 19:03 jadekstewart3

Honestly, I expected as much -- I'm pretty sure it's really quite hard!

cielf avatar Mar 05 '24 01:03 cielf

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Apr 05 '24 00:04 github-actions[bot]

Very nearly done!

cielf avatar Apr 05 '24 14:04 cielf