human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

additional characters to be accepted for password

Open seagivens opened this issue 2 years ago • 1 comments

Checklist:

  • [X] I have performed a self-review of my own code,
  • [ ] I have commented my code, particularly in hard-to-understand areas,
  • [ ] I have made corresponding changes to the documentation,
  • [X] I have added tests that prove my fix is effective or that my feature works,
  • [X] New and existing unit tests pass locally with my changes ("bundle exec rake"),
  • [ ] Title include "WIP" if work is in progress.

Resolves #3789

Description

expanded the list of special characters that are accepted to satisfy the password strength requirements, as described in Bug #3789

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

added new unit tests

seagivens avatar Nov 09 '23 01:11 seagivens

@seagivens lint is failing - can you please fix? Otherwise looks good!

dorner avatar Nov 10 '23 15:11 dorner

Very very delayed but I think this is good to merge! This slipped between the cracks.

dorner avatar Mar 08 '24 21:03 dorner

@seagivens: Your PR additional characters to be accepted for password is part of today's Human Essentials production release: 2024.03.17. Thank you very much for your contribution!

github-actions[bot] avatar Mar 17 '24 14:03 github-actions[bot]