human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

[BUG] Attachments not saving in partner profile

Open cielf opened this issue 2 years ago • 9 comments

Summary

Attachments on partner profiles are not saving. Fix it.

Why

Because sometimes the banks need the documents the partners upload as part of their approval process.

Details

@cielf discovered this while debugging another issue. Initial investigation suggests that there are some reloads that were added in when we added in the counties that are blowing away the actual contents of the attachment so it can't be saved (per @dorner)

Followup that will be needed

Once we have this fixed, we'll need to check if there are any uploads in the period between when it started (April/May .. we'll need to check to find the exact date)

Criteria for completion

  • [ ] saving the attachments works
  • [ ] tests to demonstrate this
  • [ ] the counties validations still work (that's the primal source of the issue -- the reloads are there because of something funky with the validations)
  • [ ] PR includes note about followup required.

cielf avatar Jul 23 '23 14:07 cielf

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Aug 28 '23 00:08 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Sep 05 '23 00:09 github-actions[bot]

PR is https://github.com/rubyforgood/human-essentials/pull/3782

dorner avatar Nov 05 '23 16:11 dorner

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Dec 06 '23 00:12 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Dec 13 '23 00:12 github-actions[bot]

I will take a look at it and see if the existing PR fixes the issue.

patelkrunal31 avatar Dec 17 '23 16:12 patelkrunal31

Hey @patelkrunal31 What was the result of your investigation?

cielf avatar Jan 08 '24 20:01 cielf

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Feb 08 '24 00:02 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Feb 15 '24 00:02 github-actions[bot]

TODO onthis -- write up the very edge case (see the PR) as a more specific issue, and then close this one.

cielf avatar May 24 '24 15:05 cielf

Proto issue added -- at a "this is happening in production" level, because it has in the last month. Closing this issue.

cielf avatar Jun 19 '24 18:06 cielf