rubyforgood
#3052 Confirmation page for partners requests
Resolves #3052
What I did
I made confirmation pages for Essentials Requests for request types: quantity, child, and # of individuals
I followed a similar pattern for both individual and quantity requests using a link tag passing private params to make the request from the confirmation page
For family requests I had to create a hidden form to pass the the child_id's
new version
previous version
@dorner tests are failing for me since merging to main - going to take a deeper look but I made revisions to my code for you to take a look at
Still thinking on how to improve the ui/ux of these pages
They look awkward to me
edit: stand by on review Daniel Trejo is going to get back to me with some UI recommendations
@dorner Going to throw screenshots up shortly, made the UI have a better visual hierarchy from Daniel's advice
Left the screenshots of the original version up, let me know which one you like better
@cielf thoughts? Now that I look at it, I think the "are you sure?" question and the "please confirm this is what you meant to request" seem redundant.
I agree that it's redundant. From the screenshots, I'd say to take out the "Please confirm...." I haven't kicked the tires yet.
@lokisk1155 See this screenshot, from quantity request. There should be a number in "You have requested a total of items".
And when I hit "go back", it only showed the value that was entered for the first item, which -- and not the total values I entered for that (I had entered 5 L/XL, 15 premie, and an additional 20 L/XL).
The same problem happens on individual.
For the child request, can we get the list in alpha order by child (last name, first name), then item name? Will be much easier to check for them
On Individual, at least, the totals aren't actually totalling, if I put two lines for the same item in.
@dorner @cielf I ended up refactoring how family_requests is working; I noticed that I was having issues requesting multiple items for the same child -> led to a hard refactor. / is this how it should actually work
Aside from that, I cleaned up a majority of the issues @cielf mentioned. Just need to fix the quantity and individual back button - taking a break but hopefully fixed today
@lokisk1155 Please do -- we're going to be making a concentrated effort to get the pile of unresolved PRs resolved once the two big things we are working on at the moment are done -- at that point if there's no action within 2 weeks, we'll likely just take it over -- it'd be nice to have you see it through, though.