human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Add pagination to superusers organizaation view

Open cielf opened this issue 2 years ago • 13 comments

Summary

Add pagination to superusers organization view

Why

Ease of use and speed-- there are more registered organizations than can be comfortably dealt with on a single page

Details

Follow the pattern of the superusers users view

Criteria for completion

  • [ ] Superuser's organization view is paginated
  • [ ] tests to support this functionality

cielf avatar Mar 19 '23 14:03 cielf

@cielf I can work on this.

Learningstuff98 avatar Mar 19 '23 19:03 Learningstuff98

@cielf I have a question regarding the testing situation for this. Each page is currently set to have 50 items per page. In order to test the pagination functionality I would need to instantiate 50+ organization instances for just a handful of tests. It seems to me like this would be taxing/inefficient and as such is probably not worth it. I'm wondering what your take on this is.

Learningstuff98 avatar Mar 21 '23 20:03 Learningstuff98

@Learningstuff98 you can reconfigure Kaminari in rails_helper.rb to have (say) 3 per page and then instantiate 4 of them :smile:

dorner avatar Mar 21 '23 20:03 dorner

@dorner Thanks for the info! I'll look into this.

Learningstuff98 avatar Mar 21 '23 21:03 Learningstuff98

This issue has been inactive for 243 hours (10.13 days) and will be automatically unassigned after 117 more hours (4.88 days).

github-actions[bot] avatar Apr 01 '23 00:04 github-actions[bot]

This is still being worked on.

Learningstuff98 avatar Apr 03 '23 18:04 Learningstuff98

This issue has been inactive for 245 hours (10.21 days) and will be automatically unassigned after 115 more hours (4.79 days).

github-actions[bot] avatar Apr 14 '23 00:04 github-actions[bot]

This issue has been inactive for 365 hours (15.21 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.

github-actions[bot] avatar Apr 19 '23 00:04 github-actions[bot]

Current state of this is that there is an open PR that needs some work on the tests. @Learningstuff98 has gone as far as they can with it, so one of the contributors should take it the rest of the way.

cielf avatar Apr 20 '23 21:04 cielf

@cielf I'd be happy to take a look at this, if this is still needed.

AbuMareBear avatar Sep 27 '23 16:09 AbuMareBear

@AbuMareBear go for it!

dorner avatar Sep 27 '23 17:09 dorner

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Oct 28 '23 00:10 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Nov 04 '23 00:11 github-actions[bot]