human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Published 20 hours ago • verified publisher icon rubyforgood

3088 distribution pdf

Open dorner opened this issue 1 year ago • 1 comments

Resolves #3088

Description

This updates the output of the distribution PDF when there is an associated request.

I've done a minor refactor of the LineItem class to accommodate the requested changes.

Please see screenshots. The "request" version of it is missing a border on the bottom right of the data table - I couldn't figure out how to put it back and I ran out of time. We can decide if that's a blocker or if we can merge as is.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Local/unit tests

Screenshots

image image

dorner avatar Sep 09 '22 20:09 dorner

Thanks @dorner -- I probably won't get to this until at least Wednesday, because life.

cielf avatar Sep 12 '22 22:09 cielf

Still pending some fixes and after that I think we mergey merge

edwinthinks avatar Sep 25 '22 13:09 edwinthinks

Ack, forgot to push my commit! 😮

dorner avatar Sep 28 '22 13:09 dorner

@edwinthinks I think this should be good now.

dorner avatar Oct 14 '22 17:10 dorner

@edwinthinks thanks for the QA - it should be fixed now!

dorner avatar Oct 21 '22 19:10 dorner

Awesome! Thanks @dorner just QA'ed this and it works.

A bit of a side thought for a future issue, perhaps we can use something like https://adminlte.io/themes/v3/pages/examples/invoice.html from the theme which allows us to consolidate the printing and the show page of distributions. I figure this data could be helpful outside of the PDF. Lemme know what you think.

edwinthinks avatar Oct 29 '22 21:10 edwinthinks

That looks interesting! Definitely worth looking into next time we do something like this.

dorner avatar Oct 29 '22 23:10 dorner