human-essentials
human-essentials copied to clipboard
rubyforgood
Add a confirmation page to partner requests.
Summary
Add a confirmation step to partner requests
Justification
Non-profits are often staffed with folks with limited technical skills and sometimes make mistakes with their requests. This puts and extra burden on the essentials banks as they then need to get in contact with their partners and see if they really did intend to order 5000 rather than their usual 500 diapers. We need to add in a confirmation page summarizing the request and ask for confirmation from the partner before this request is placed to the diaper bank.
Details
There are three different ways to make a request (partners/requests/new, partners/family_requests/new, partners/individuals_request/new). The confirmation page information is the same for each of them
It will show a list of the items requested and number requested for each, along with the text "Please confirm that the above list is what you meant to request" and buttons "No, I need to change something." and "Yes, it's right"
Additionally, if a quota is in place, warn partners from accidentally making a request that is over the quota unintentionally. "Oops! You are ordering 9999999 of something, are you sure?"
Clicking "No..." will take them back to the requests page they came from so that they can adjust their ask. Clicking "Yes..." will take them to the current
Clicking "Yes" will submit the request and show the submitted page for that request, as it does now.
Things we should know
History: This was raised by Sean a long time ago as https://github.com/rubyforgood/partner/issues/354. There was even a pull request for it. It was closed but remained on the project initiatives board. CL took the backlogs for partner-facing items to the July 2022 partnerbase working group, where this was identified as one of the higher priority asks, as it does burden the essentials banks.
There has been some discussion in the partnerbase working group about whether the quota is a weekly or monthly quota. For the purposes of this issue, treat it as a per request quota of total items, as most partners only do one request for month.
Criteria for Completion
-[] Add in a confirmation page when partners issue a request, as described above -[] Add in relevant tests -[] Tests pass
Sounds good to me
Sent from my iPhone
On Jul 31, 2022, at 7:15 AM, Edwin Mak @.***> wrote:
@cielf I'd love to take this one :)
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.
This issue has been inactive for 251 hours (10.46 days) and will be automatically unassigned after 109 more hours (4.54 days).
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue has been inactive for 250 hours (10.42 days) and will be automatically unassigned after 110 more hours (4.58 days).
This issue has been inactive for 370 hours (15.42 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.
I'm pretty sure this is no longer blocked on #3214. Not sure what the issue was that was blocking it before -- @edwinthinks - can you clarify -- is it blocked for you, because of need of help with thinking of the UX, or blocked for anybody?
@lokisk1155 this and the other one are both pretty hefty pieces of work. I'd suggest picking one.
@dorner cielf said that this one and #3090 are very similar so it makes sense to take both. But I can start with just one.
Well - it's also possible that you'll run out of time on one before finishing the other -- it's the same pattern, but @dorner is right that they are good chunks of work. They are also old enough that the odds of someone else taking the other one in the meantime is relatively low.
@cielf @dorner Np I will start with this one because you guys are already in the thread
This issue has been inactive for 248 hours (10.33 days) and will be automatically unassigned after 112 more hours (4.67 days).
This issue has been inactive for 368 hours (15.33 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.
Is this still in a help wanted status? I was looking for a next issue to pick up, but then noticed there's an open PR from about a year ago: https://github.com/rubyforgood/human-essentials/pull/3638
@danielabar this is a pretty meaty change - it might make sense to grab that PR and use it as a basis for a new PR. It's pretty out of date and has a bunch of conflicts at this point.
(Note -- @danielabar is doing #3090 first, but I would consider this reserved for her for the next couple of weeks anyway.)