System Test Overhaul spec/system/reimbursements/reimbursements_spec.rb

[FireLemons]

Description

ensure each test in spec/system/reimbursements/reimbursements_spec.rb is checking for database updates after the page has finished loading after a submit

See: https://github.com/rubyforgood/casa/pull/6305 for an example

Other improvements to tests in the file are welcome

If there are none, leave a comment on this issue and we will close the issue

Login Emails for test environment:

• [email protected] view site as a volunteer
• [email protected] view site as a supervisor
• [email protected] view site as an admin
• [email protected] view site as an all casa admin
  • go to /all_casa_admins/sign_in

password for all users: 12345678

Questions? Join Slack!

We highly recommend that you join us in slack #casa channel to ask questions quickly. And discord for office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

[github-actions[bot]]

This issue has been open without changes for a long time! What's up?

[marcospedro97]

Hi @FireLemons can I work on it?

[compwron]

go for it :)

[FireLemons]

There's nothing to do on this issue because all the tests don't directly check the database so there's no race condition between the page loading and the database check

[FireLemons]

@marcospedro97 Try this one. There are some ActionMailer checks that don't wait for the page to load.

[marcospedro97]

Ok, thanks