System Test Overhaul spec/system/case_court_reports/index_spec.rb

[FireLemons]

Description

ensure each test in spec/system/case_court_reports/index_spec.rb is checking for database updates after the page has finished loading after a submit

See: https://github.com/rubyforgood/casa/pull/6305 for an example

Other improvements to tests in the file are welcome

If there are none, leave a comment on this issue and we will close the issue

Login Emails for test environment:

• [email protected] view site as a volunteer
• [email protected] view site as a supervisor
• [email protected] view site as an admin
• [email protected] view site as an all casa admin
  • go to /all_casa_admins/sign_in

password for all users: 12345678

Questions? Join Slack!

We highly recommend that you join us in slack #casa channel to ask questions quickly. And discord for office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

[github-actions[bot]]

This issue has been open without changes for a long time! What's up?

[theomelo]

I would like to work on this one!

[FireLemons]

Add to spec/requests/case_court_reports_spec.rb and spec/system/reports/index_spec.rb tests for date filtering.

Add to spec/system/reports/index_spec.rb tests for the correct cases appearing the autocomplete. The correct cases for a volunteer are all the cases the volunteer is assigned to. The correct cases for a supervisor/admin are all of the cases belonging to their parent organization. The dropdown for a supervisor/admin is powered by a widget that requires js. It would be nice to consolidate the admin and supervisor tests to reuse the same code because the site behaves the same for them(optional).

[github-actions[bot]]

This issue has been inactive for 240 hours (10.00 days) and will be unassigned after 120 more hours (5.00 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

[github-actions[bot]]

This issue has been inactive for 360 hours (15.00 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.

[AudTheCodeWitch]

I'll look at this one today.

[AudTheCodeWitch]

This test file is very flaky locally. I'm working to address that as part of this ticket. However, I am going on a week-long trip starting tomorrow, and I don't think I'll have the chance to finish this before then. I'll put up a draft PR with whatever I have at the end of the day, in case someone wants to take it from there. Otherwise, I'll pick it up again when I get back.

[compwron]

:)

[AudTheCodeWitch]

Just a quick update: I am still working on this (almost there)!

[AudTheCodeWitch]

Phew! That one was a doozy, but it's ready for review now!