casa icon indicating copy to clipboard operation
casa copied to clipboard

5847 surface common filters

Open mononoken opened this issue 7 months ago β€’ 0 comments

What github issue is this PR for, if any?

Resolves #5847

What changed, and why?

  • Moved the Sorted by and Hide drafts filter options outside of the collapsable area of the form element, so that they display regardless of filter menu collapse status.
  • Fixed the positioning of the form select pseudo icons by refactoring the HTML syntax around the select elements
  • Changed the filter-card-body collapse class logic to, fix a bug where the "Expand / show" button did not respond to the first click after filtering. This change accounts for how Bootstrap implements its version of collapse.

How is this tested? (please write tests!) πŸ’–πŸ’ͺ

I did not add any new tests, since this was only a matter of changing options that are collapsed. However, I did update the button text and the tests that expected the old text.

I can add some system tests to check that the "sticky" options are always displayed if that is desired.

Screenshots please :)

SCR-20240629-swmf SCR-20240629-swrz

Feelings gif (optional)

Instead of a gif, I asked ChatGPT to write a haiku about Bootstrap. γƒ–γƒΌγƒˆγ‚Ήγƒˆγƒ©γƒƒγƒ— εˆΆη΄„γ‚’ζ„Ÿγ˜γ¦ θ‡ͺ由を求め

mononoken avatar Jun 30 '24 05:06 mononoken