rubyforgood
added additional logic to contact_topic_answers to improve discoverab…
What github issue is this PR for, if any?
Resolves #5775
What changed, and why?
I added additional logic to contact_topic_answers to improve discoverability for case topics if admin has not set any court report topics. This was important because users did not know admins needed to set court report topics in order for the feature to be accessible by volunteers, supervisors, and admins.
How is this tested? (please write tests!) 💖💪
This was tested by removing all topics from Court Report Topics as an admin, then logging in as each user type and confirming what verbiage was displayed as it needed to be different for admins versus volunteers and supervisors.
I then logged in as an admin then set court report topics and repeated the process of logging in as each user type to confirm court report topics would be visible.
For each test, I inspected the code and simulated being in a different browser type (mobile, tablet, laptop) to confirm the CSS classes conformed with the rest of the page.\
Screenshots please :)
Feelings gif (optional)
_What gif best describes your feeling working on this issue? https://giphy.com/
@compwron can you help guide on next steps for the two failures?
Those are false positives. Unfortunately there are issues with some tests timing out and looking like failures.
So your pr passes the test suite.
Looks good! Sorry about the flaky spec.
1) case_contacts/index with case contacts without filter displays the contact type groups
Failure/Error: expect(page).to have_text(case_contacts[2].contact_groups_with_types.keys.first)
expected to find text "Group 1388" in "Group 1389\nDraft"
@josephmsmith this is super minor thing but FYI in git commits you typically want to write in the first line main point of the commit in 80 chars or less. then have an empty line the write the body of the commit which has move context.
you have a few commits where the wrote a really long first line of they look like
vs