casa icon indicating copy to clipboard operation
casa copied to clipboard

WIP: [FEAT] Custom Links in Dropdown Menu

Open nepaakash opened this issue 1 year ago • 5 comments

What github issue is this PR for, if any?

Resolves #5704

What changed, and why?

How is this tested? (please write tests!) 💖💪

Note: if you see a flake in your test build in github actions, please post in slack #casa "Flaky test: " :) 💪 Note: We love capybara tests! If you are writing both haml/js and ruby, please try to test your work with tests at every level including system tests like https://github.com/rubyforgood/casa/tree/main/spec/system

Screenshots please :)

Run your local server and take a screenshot of your work! Try to include the URL of the page as well as the contents of the page.

Feelings gif (optional)

What gif best describes your feeling working on this issue? https://giphy.com/ How to embed: ![alt text](https://media.giphy.com/media/1nP7ThJFes5pgXKUNf/giphy.gif)

nepaakash avatar May 13 '24 16:05 nepaakash

@nepaakash how are you coming along here? :) do you need any help?

bcastillo32 avatar Jun 22 '24 19:06 bcastillo32

@nepaakash how are you coming along here? :) do you need any help?

Thankyou for asking. Everything is good , Apologies for the delay. Just a quick question, are we not showing any icons for the custom links?

nepaakash avatar Jun 23 '24 18:06 nepaakash

Just a quick question, are we not showing any icons for the custom links?

@nepaakash Thats a good question. We should. You can just use a basic link icon <i class="lni lni-link"></i>.

Also, we don't need the soft delete behavior for these links. Soft delete is needed with topics because deletion would impact historical data but that is not the case here.

elasticspoon avatar Jun 23 '24 18:06 elasticspoon

@nepaakash Getting this when spinning up locally. Screenshot 2024-06-29 at 7 57 38 AM

Probably these references.

Screenshot 2024-06-29 at 8 00 15 AM

schoork avatar Jun 29 '24 12:06 schoork

@nepaakash Getting this when spinning up locally. Screenshot 2024-06-29 at 7 57 38 AM

Probably these references.

Screenshot 2024-06-29 at 8 00 15 AM

@schoork Sorry! I have already fixed that issue locally. I will just push it.

nepaakash avatar Jun 29 '24 14:06 nepaakash

This PR has been open for a long time without any pushes or comments! What's up?

github-actions[bot] avatar Oct 28 '24 02:10 github-actions[bot]

hi @nepaakash - I hope you are well. CASA stakeholders asked about this yesterday. Anything else needed on this ticket to get it completed?

bcastillo32 avatar Jan 26 '25 01:01 bcastillo32

hi @nepaakash - I hope you are well. CASA stakeholders asked about this yesterday. Anything else needed on this ticket to get it completed?

Hey @bcastillo32 , RSpecs is remaining in this

nepaakash avatar Jan 27 '25 16:01 nepaakash

I am excited for this to get merged, feel free to ask me any questions

compwron avatar Jan 27 '25 17:01 compwron

hi @nepaakash - I hope you are well. CASA stakeholders asked about this yesterday. Anything else needed on this ticket to get it completed?

Hey @bcastillo32 , RSpecs is remaining in this

hi @nepaakash - how are you coming along - our stakeholders are keen on using this feature :)

bcastillo32 avatar Feb 09 '25 16:02 bcastillo32

hi @nepaakash - I hope you are well. CASA stakeholders asked about this yesterday. Anything else needed on this ticket to get it completed?

Hey @bcastillo32 , RSpecs is remaining in this

hi @nepaakash - how are you coming along - our stakeholders are keen on using this feature :)

Will complete the task by the end of this week

nepaakash avatar Feb 10 '25 16:02 nepaakash

hi @nepaakash - I hope you are well. CASA stakeholders asked about this yesterday. Anything else needed on this ticket to get it completed?

Hey @bcastillo32 , RSpecs is remaining in this

hi @nepaakash - how are you coming along - our stakeholders are keen on using this feature :)

Will complete the task by the end of this week

Hi @nepaakash any progress on this. Our casa stakeholders are inquiring :)

bcastillo32 avatar Mar 21 '25 18:03 bcastillo32

hi @nepaakash - I hope you are well. CASA stakeholders asked about this yesterday. Anything else needed on this ticket to get it completed?

Hey @bcastillo32 , RSpecs is remaining in this

hi @nepaakash - how are you coming along - our stakeholders are keen on using this feature :)

Will complete the task by the end of this week

Hi @nepaakash any progress on this. Our casa stakeholders are inquiring :)

Hello @bcastillo32 everything is done here but the rspec is failing. I checked and it is failing in the main branch too. Cam you look into it?

nepaakash avatar Mar 25 '25 08:03 nepaakash

closing

bcastillo32 avatar Mar 31 '25 23:03 bcastillo32