casa icon indicating copy to clipboard operation
casa copied to clipboard

Remove the global <span> tag CSS

Open chahmedejaz opened this issue 1 year ago • 3 comments

Description

  • We are globally overriding the <span> tag's inline display behavior to the block as per below:
  • https://github.com/rubyforgood/casa/blob/7dc1c6bd7aaf587e1ee146fd50218d470076375d/public/assets/css/main.css#L56-L59
  • IMO, this kills the purpose of the span tag in general
  • We have other alternatives to achieve the display block behavior e.g. <p>, <div> etc
  • We need to remove the code chunk shown above (surpizingly there's a syntax error in the current main.css as well at line#59 and it's not breaking:sweat_smile:)
  • Along with that we need to update the whole application where the current span styling is required or breaks the UI in any way. For example, removing this chunk breaks the styles on the Supervisors index page view

Existing global span style needs deleting

  • https://github.com/rubyforgood/casa/blob/7dc1c6bd7aaf587e1ee146fd50218d470076375d/public/assets/css/main.css#L56-L59

New style(s) needs creating

  • New styles or alternatives needs to be created/replaced throughout the app to ensure that nothing breaks after the removal of above chunk

chahmedejaz avatar Nov 16 '23 08:11 chahmedejaz

Hi @chahmedejaz i can work on this. can you pls assign it to me

Nwabor avatar Jan 05 '24 16:01 Nwabor

Thanks for your interest on it, @Nwabor Hey @bcastillo32 can we please assign it to him? Thanks.

chahmedejaz avatar Jan 08 '24 09:01 chahmedejaz

This issue has been open without changes for a long time! What's up?

github-actions[bot] avatar Mar 10 '24 01:03 github-actions[bot]