casa icon indicating copy to clipboard operation
casa copied to clipboard

Published 20 hours ago • verified publisher icon rubyforgood

[WIP] Update "3. Enter Contact Details" section on Case contact form

Open ahasunos opened this issue 1 year ago • 10 comments

What github issue is this PR for, if any?

Resolves #5348

This PR is a work-in progress (waiting on some style changes: bold <> light labels and asterisk on next line <> same line from #5366)

What changed, and why?

Updated UI changes for "3. Enter Contact Details" section as per Figma file and some other styles need to be applied.

  • Update 3. Enter Contact Details to 3. Record contact details and it's style
  • Update a. Contact Made to a. Was contact made?
  • Update b. Contact Medium to b. How was contact made?
  • Update c. Occurred On to c. Date of contact
  • Update d. Duration of Meeting to d. Duration of contact
  • Update date format for c. Date of contact from yyyy/mm/dd to mm/dd/yyyy, and include a placeholder for the same.
  • Remove explicit hours and minutes text from d. Duration of contact's hour and minute field to have placeholder as 0 hour(s) and 0 minute(s)
  • Update contact medium texts and change formatting from titleize to capitalize

How will this affect user permissions?

  • Volunteer permissions:
  • Supervisor permissions:
  • Admin permissions:

How is this tested? (please write tests!) 💖💪

Screenshots please :)

ahasunos avatar Nov 15 '23 20:11 ahasunos

hi @ahasunos do you mind providing some screenshots? 😁

bcastillo32 avatar Nov 16 '23 00:11 bcastillo32

hi @ahasunos do you mind providing some screenshots? 😁

It still is a wip, but I am getting there slowly. image

I am fairly new to the rails environment. So, I am taking some time here.

ahasunos avatar Nov 16 '23 10:11 ahasunos

Whenever I provide any input to the Miles driven field, I get the pop-up. Any idea on this how to fix? This is happening for me even on the main branch image

ahasunos avatar Nov 16 '23 19:11 ahasunos

Whenever I provide any input to the Miles driven field, I get the pop-up. Any idea on this how to fix? This is happening for me even on the main branch

@ahasunos I believe this is intentional and has to do with the In Person medium not being checked. For the life of me, I cannot find the code that does this. Was thinking it was in app/javascript/src/case_contact.js, but can't find it.

schoork avatar Nov 18 '23 13:11 schoork

@ahasunos It's in app/javascript/src/validated_form.js (line 315)

schoork avatar Nov 18 '23 13:11 schoork

@ahasunos - As the #5366 has been merged, please rebase your branch with the latest main to get the required styling as per this. Thanks.

chahmedejaz avatar Nov 22 '23 07:11 chahmedejaz

hi @ahasunos how are you coming along on this? :)

bcastillo32 avatar Jan 05 '24 01:01 bcastillo32

hi @bcastillo32 I have been offline for a while, will look back again!

ahasunos avatar Jan 05 '24 06:01 ahasunos

hi @bcastillo32 I have been offline for a while, will look back again!

Ok great. Please do. This is a big focus for us and our end users. :) Let us know how we can be of help.

bcastillo32 avatar Jan 07 '24 23:01 bcastillo32

This PR has been open for a long time without any pushes or comments! What's up?

github-actions[bot] avatar Mar 10 '24 01:03 github-actions[bot]

Hi @ahasunos Are you able to work on this? We are near completion of this refactor and would love for this to be complete :)

bcastillo32 avatar Apr 07 '24 23:04 bcastillo32

This PR is so old and so merge conflicted. I'm sorry we didn't get this over the line. I am going to close it for now because I want to not have old stale PRs on the dashboard. Feel free to pick it back up - maybe in smaller chunks?

compwron avatar Apr 14 '24 18:04 compwron

@compwron Sorry about the incomplete work. Will try to pick back up in smaller chunks.

ahasunos avatar Apr 15 '24 08:04 ahasunos