casa
casa copied to clipboard
Make Double Language Add Error Message Full Width of Parent
What type(s) of user does this feature affect?
- volunteers
Description
Go to page /users/edit
. Input some invalid values for name or email (such a blank inputs) and press update. You get an error.
Make the error shown below the width of the parent container with some margin.
Screenshots of current behavior
How to access the QA site
Login Details:
Link to QA site
Login Emails:
- [email protected] view site as a volunteer
- [email protected] view site as a supervisor
- [email protected] view site as an admin
- [email protected] view site as an all casa admin
- go to
/all_casa_admins/sign_in
- go to
password for all users: 12345678
Questions? Join Slack!
We highly recommend that you join us in slack https://rubyforgood.herokuapp.com/ #casa channel to ask questions quickly and hear about office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.
I would like to help with this issue
I would love to work on this if possible!
@FireLemons @schoork does this look correct? Is there anything I should change?
This issue has been inactive for 241 hours (10.04 days) and will be unassigned after 119 more hours (4.96 days). If you have questions, please
If you are still working on this, comment here to tell the bot to give you more time
waiting for response
@mattpettenato Honestly not sure. But that does look right. Did you check mobile views, too?
This issue has been inactive for 252 hours (10.50 days) and will be unassigned after 108 more hours (4.50 days). If you have questions, please
If you are still working on this, comment here to tell the bot to give you more time
This issue has been inactive for 373 hours (15.54 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.
@mattpettenato seems like it's pretty close if it's not already there. Do you have a PR to take a look at?
Hi, I would love to work on this. I have some doubts. Shall we discuss here or at the slack channel?
These are my doubts
- Can we show the add languages option only if there are languages remaining to select other than volunteer's current languages ?
- Also, in case of showing the languages list we can avoid listing the current languages of volunteer thus eliminating the need for this error message altogether.
Can i proceed along this line?
Commenting for follow up. Is this issue still available to work on? @mattzollinhofer
This issue has been open without changes for a long time! What's up?
This issue has been open without changes for a long time! What's up?
Noticing some quietness on this issue. I have fixed this locally and can create a PR if it is assigned to me.
@jamesh38 send it!
Sure thing how's this looking https://github.com/rubyforgood/casa/pull/5956