casa icon indicating copy to clipboard operation
casa copied to clipboard

Make Double Language Add Error Message Full Width of Parent

Open FireLemons opened this issue 1 year ago • 12 comments

What type(s) of user does this feature affect?

  • volunteers

Description

Go to page /users/edit. Input some invalid values for name or email (such a blank inputs) and press update. You get an error.

Make the error shown below the width of the parent container with some margin.

Screenshots of current behavior

image

How to access the QA site

Login Details:
Link to QA site

Login Emails:

password for all users: 12345678

Questions? Join Slack!

We highly recommend that you join us in slack https://rubyforgood.herokuapp.com/ #casa channel to ask questions quickly and hear about office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

FireLemons avatar Sep 02 '23 18:09 FireLemons

I would like to help with this issue

jp524 avatar Sep 04 '23 20:09 jp524

I would love to work on this if possible!

mattpettenato avatar Sep 05 '23 23:09 mattpettenato

image

@FireLemons @schoork does this look correct? Is there anything I should change?

mattpettenato avatar Oct 04 '23 22:10 mattpettenato

This issue has been inactive for 241 hours (10.04 days) and will be unassigned after 119 more hours (4.96 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

github-actions[bot] avatar Oct 15 '23 00:10 github-actions[bot]

waiting for response

mattpettenato avatar Oct 17 '23 01:10 mattpettenato

@mattpettenato Honestly not sure. But that does look right. Did you check mobile views, too?

schoork avatar Oct 17 '23 11:10 schoork

This issue has been inactive for 252 hours (10.50 days) and will be unassigned after 108 more hours (4.50 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

github-actions[bot] avatar Oct 28 '23 00:10 github-actions[bot]

This issue has been inactive for 373 hours (15.54 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.

github-actions[bot] avatar Nov 02 '23 00:11 github-actions[bot]

@mattpettenato seems like it's pretty close if it's not already there. Do you have a PR to take a look at?

mattzollinhofer avatar Nov 04 '23 01:11 mattzollinhofer

Hi, I would love to work on this. I have some doubts. Shall we discuss here or at the slack channel?

These are my doubts

  • Can we show the add languages option only if there are languages remaining to select other than volunteer's current languages ?
  • Also, in case of showing the languages list we can avoid listing the current languages of volunteer thus eliminating the need for this error message altogether.

Can i proceed along this line?

atbalaji avatar Dec 04 '23 06:12 atbalaji

Commenting for follow up. Is this issue still available to work on? @mattzollinhofer

atbalaji avatar Dec 31 '23 22:12 atbalaji

This issue has been open without changes for a long time! What's up?

github-actions[bot] avatar Mar 01 '24 01:03 github-actions[bot]

This issue has been open without changes for a long time! What's up?

github-actions[bot] avatar Jul 19 '24 01:07 github-actions[bot]

Noticing some quietness on this issue. I have fixed this locally and can create a PR if it is assigned to me.

Screenshot 2024-07-29 at 10 46 04 PM Screenshot 2024-07-29 at 10 45 50 PM Screenshot 2024-07-29 at 10 46 30 PM Screenshot 2024-07-29 at 10 46 46 PM

jamesh38 avatar Jul 30 '24 02:07 jamesh38

@jamesh38 send it!

elasticspoon avatar Jul 30 '24 03:07 elasticspoon

Sure thing how's this looking https://github.com/rubyforgood/casa/pull/5956

jamesh38 avatar Jul 30 '24 21:07 jamesh38