casa
casa copied to clipboard
rubyforgood
[WIP] Fix Add Language error on empty language
What github issue is this PR for, if any?
Resolves #3960
What changed, and why?
How will this affect user permissions?
- Volunteer permissions:
- Supervisor permissions:
- Admin permissions:
How is this tested? (please write tests!) 💖💪
Screenshots please :)
Feelings gif (optional)
What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
Feedback please? (optional)
We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9
Current behavior: When using the 'Add language' drop-down on the 'Edit User's Profile' page logged in as a Volunteer:
- Adding a specific language works as expected
- Deleting a specific language works as expected
- Adding a 'blank' language (default from the _languages partial in the Users folder) does not break the page as it did before but also does not yet provide an error message alerting the user that they can not choose a 'blank' language.
Hi! Good!
The functionality for the issue is currently working as expected. Because we also moved a method from the languages_controller to the users_controller we are having to write/rewrite/modify a lot of tests. There is a counterpart method that will need to be moved as well to match. (add_language, remove_language). We added a new issue for this. #4079.
So, although the behavior is correct when testing manually, the testing is not complete.
: )
On Mon, Oct 17, 2022 at 6:36 PM compwron @.***> wrote:
How's this going? It looks promising! :)
— Reply to this email directly, view it on GitHub https://github.com/rubyforgood/casa/pull/4056#issuecomment-1281696805, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR3VCDIUOZFIIRYZE544OITWDX5IPANCNFSM6AAAAAARC2LXFQ . You are receiving this because you authored the thread.Message ID: @.***>
Thank you!
: )
Eric
On Oct 31, 2022, at 15:50, compwron @.***> wrote:
Merged #4056 into main.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were assigned.