casa icon indicating copy to clipboard operation
casa copied to clipboard

update bootstrap version

Open italomatos opened this issue 3 years ago • 6 comments

What github issue is this PR for, if any?

Resolves #3962

What changed, and why?

update boostrap version from 4.6.2 to 5.2.1 version.

How will this affect user permissions?

  • Volunteer permissions:
  • Supervisor permissions:
  • Admin permissions:

italomatos avatar Sep 26 '22 01:09 italomatos

@italomatos thanks for tackling this! How is it going? Do you need any help?

littleforest avatar Sep 30 '22 18:09 littleforest

@italomatos thanks for tackling this! How is it going? Do you need any help?

Hi @littleforest , when I updated bootstrap lib, some tests broken, I'm trying to find a problem and fix them. I have not understand why.

bin/rspec ./spec/system/notifications/index_spec.rb:93

italomatos avatar Oct 01 '22 00:10 italomatos

@italomatos thanks for tackling this! How is it going? Do you need any help?

Hi @littleforest , when I updated bootstrap lib, some tests broken, I'm trying to find a problem and fix them. I have not understand why.


bin/rspec ./spec/system/notifications/index_spec.rb:93

done :) ready for review 🚀🚀

italomatos avatar Oct 01 '22 14:10 italomatos

I do think that some of these changes that littleforest posted above are removing formatting that we want

compwron avatar Oct 04 '22 04:10 compwron

Screen Shot 2022-10-04 at 7 39 53 PM It looks like the modal doesn't close after creating a case contact- this is a problem

compwron avatar Oct 05 '22 02:10 compwron

On the http://127.0.0.1:3000/volunteers page none of the filter views respond to click Screen Shot 2022-10-04 at 7 42 28 PM

compwron avatar Oct 05 '22 02:10 compwron

I would love to update this and be able to merge it, do you think you'll come back to this @italomatos ? it's ok if not but if not then we should free it up to be assigned to someone else

compwron avatar Nov 09 '22 03:11 compwron