casa icon indicating copy to clipboard operation
casa copied to clipboard

Status filter no longer works on Supervisors page

Open aedwardg opened this issue 3 years ago • 3 comments

Impacted User Types

  • volunteers? ❌
  • supervisors? ✔️
  • admins? ✔️
  • all casa admins? ❌

Environment

All environments, I believe (tested on local and QA with Firefox and Chrome)

Current Behavior

When I try to filter Supervisors by activity status nothing changes. For example, selecting only "Inactive" supervisors does not remove the active supervisors from the list.

image

Expected Behavior

Status filter should work as it does on the Volunteers page

How to Replicate

    • Log into staging as an admin or supervisor.
    • Click on "Status" at the top of the page to filter by activity status.
    • Watch as nothing happens.

QA Login Details:

Link to QA site

Login Emails:

password for all users: 12345678

Questions? Join Slack!

We highly recommend that you join us in slack https://rubyforgood.herokuapp.com/ #casa channel to ask questions quickly and hear about office hours (currently Wednesday 6-8pm Pacific), stakeholder news, and upcoming new issues.

aedwardg avatar Dec 27 '21 07:12 aedwardg

I can work on this

leevic31 avatar Jul 31 '22 17:07 leevic31

May I call dibs on this one?

matisnape avatar Oct 08 '22 22:10 matisnape

@matisnape sure!

aedwardg avatar Oct 09 '22 03:10 aedwardg

This issue has been inactive for 261 hours (10.88 days) and will be unassigned after 99 more hours (4.13 days). If you have questions, please visit the #casa channel in slack during Tuesdays 6-8 PM PST. Link: https://rubyforgood.herokuapp.com/

If you are still working on this, comment here to tell the bot to give you more time

github-actions[bot] avatar Oct 20 '22 00:10 github-actions[bot]

This issue has been inactive for 381 hours (15.88 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.

github-actions[bot] avatar Oct 25 '22 00:10 github-actions[bot]

@aedwardg May I call on this one(research already done)? And does the show activated or deactivated button, makes any sense once the fix is made? If not, I can remove it as well.. Or you rather keep the already implemented button, and get rid of the filters! Please let me know!

FranConcaro avatar Nov 12 '22 17:11 FranConcaro

@FranConcaro Sure, I'll assign this one to you. For now let's keep both the filters and the "show (de)activated" button. We may decide to remove one or the other in the future, but that decision will probably require more discussion with the project leads.

aedwardg avatar Nov 13 '22 15:11 aedwardg

This issue has been inactive for 249 hours (10.38 days) and will be unassigned after 111 more hours (4.63 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

github-actions[bot] avatar Nov 24 '22 00:11 github-actions[bot]

I need more time

FranConcaro avatar Nov 24 '22 02:11 FranConcaro

This issue has been inactive for 262 hours (10.92 days) and will be unassigned after 98 more hours (4.08 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

github-actions[bot] avatar Dec 05 '22 00:12 github-actions[bot]

Hello @aedwardg, does this issue still need to be fixed? If so, I could work on it. Please let me know!

MiguelArgentina avatar Dec 10 '22 00:12 MiguelArgentina

@MiguelArgentina yes, this is still needed, but I'm not sure if @FranConcaro is still working on it.

@FranConcaro is this something you would like to continue, or should I pass it on to Miguel?

aedwardg avatar Dec 10 '22 00:12 aedwardg

Hi! I'm sorry, the past weeks had been hard.. i rather pass it, since I don't know if I'm going to be able to finish it

FranConcaro avatar Dec 10 '22 00:12 FranConcaro

No worries! @MiguelArgentina feel free to pick this up. I'll go ahead change the assignee to you.

aedwardg avatar Dec 10 '22 00:12 aedwardg

Thanks! @FranConcaro, do you have a PR you were working on or shall I start from scratch?

MiguelArgentina avatar Dec 10 '22 00:12 MiguelArgentina

No, what I can tell you is that the idea is to handle that rails table as an ajax datatable instead, but keeping the stlye. And once the filters work, remove the show activated/deactivated button

FranConcaro avatar Dec 10 '22 00:12 FranConcaro

Thanks! I appreciate it! 😄

MiguelArgentina avatar Dec 10 '22 00:12 MiguelArgentina

This issue has been inactive for 263 hours (10.96 days) and will be unassigned after 97 more hours (4.04 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

github-actions[bot] avatar Dec 21 '22 00:12 github-actions[bot]

This issue has been inactive for 360 hours (15.00 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.

github-actions[bot] avatar Dec 25 '22 00:12 github-actions[bot]

@aedwardg can I claim this?

ThomasNathan avatar Feb 17 '23 22:02 ThomasNathan

@ThomasNathan sure, but it might be worth checking with @FireLemons to see if this is still needed. I haven't looked into it since the new UI changes began.

aedwardg avatar Feb 18 '23 00:02 aedwardg

still broken

FireLemons avatar Feb 19 '23 00:02 FireLemons

This issue has been inactive for 240 hours (10.00 days) and will be unassigned after 120 more hours (5.00 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

github-actions[bot] avatar Mar 01 '23 00:03 github-actions[bot]

This issue has been inactive for 360 hours (15.00 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.

github-actions[bot] avatar Mar 06 '23 00:03 github-actions[bot]

@dpaola2 Please reassign. Thanks

ThomasNathan avatar Mar 06 '23 01:03 ThomasNathan

I believe @crespire is working on this with @ThomasNathan

dpaola2 avatar Mar 14 '23 12:03 dpaola2

Yep, @ThomasNathan is still leading this issue! We're close!

crespire avatar Mar 14 '23 12:03 crespire

This issue has been inactive for 252 hours (10.50 days) and will be unassigned after 108 more hours (4.50 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

github-actions[bot] avatar Mar 25 '23 00:03 github-actions[bot]

Just awaiting approval on the PR!

crespire avatar Mar 25 '23 00:03 crespire

This issue has been inactive for 240 hours (10.00 days) and will be unassigned after 120 more hours (5.00 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

github-actions[bot] avatar Apr 04 '23 00:04 github-actions[bot]

I'm still working on this!

crespire avatar Apr 04 '23 12:04 crespire