casa
casa copied to clipboard
rubyforgood
re-enable pundit safety checks, fix tests
# after_action :verify_authorized, except: :index # TODO add this back and fix all tests
# after_action :verify_policy_scoped, only: :index
@compwron I can take this on. Just to be sure, you want both lines re-added?
This issue has been inactive for 249 hours (10.38 days) and will be automatically unassigned after 111 more hours (4.63 days).
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue has been inactive for 369 hours (15.38 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.
@compwron @FireLemons what are your thoughts about removing Pundit requirements for all_casa_admins controllers? An all_casa_admin user should have access to any action in those controllers (currently). I'm leaning towards just removing Pundit requirements for those controllers since everything would default to true anyway. What are your thoughts?
@compwron should any supervisor be able to edit or delete any note, even if it is not for their volunteer?
@littleforest that seems reasonable to remove for all-casa admins
re supervisors and notes... probably yes, but if it's not that way it's not a huge deal as long as admins can do it and the notes aren't volunteer-visible
This issue has been inactive for 241 hours (10.04 days) and will be unassigned after 119 more hours (4.96 days). If you have questions, please visit the #casa channel in slack during Tuesdays 6-8 PM PST. Link: https://rubyforgood.herokuapp.com/
If you are still working on this, comment here to tell the bot to give you more time
This issue has been inactive for 361 hours (15.04 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.
This issue has been inactive for 262 hours (10.92 days) and will be unassigned after 98 more hours (4.08 days). If you have questions, please visit the #casa channel in slack during Tuesdays 6-8 PM PST. Link: https://rubyforgood.herokuapp.com/
If you are still working on this, comment here to tell the bot to give you more time
This issue has been inactive for 263 hours (10.96 days) and will be unassigned after 97 more hours (4.04 days). If you have questions, please
If you are still working on this, comment here to tell the bot to give you more time
@compwron I think the last controller that needs to be fixed is the other_duties controller. I'm a little confused about that feature though. I see a link to the other_duties#index page on both Supervisor and Admins, but no link to the new page (although it exists and I can manually visit the new page). Do you know what the permissions should be like? Is someone creating a duty for themselves? From the controller index method, it looks like a duty is getting created for a volunteer, but there is no volunteer on the form field. Anyway, wondering if this feature is somewhat unfinished, but I'm not seeing any open tickets around it.
This issue has been inactive for 260 hours (10.83 days) and will be unassigned after 100 more hours (4.17 days). If you have questions, please
If you are still working on this, comment here to tell the bot to give you more time
This issue has been inactive for 257 hours (10.71 days) and will be unassigned after 103 more hours (4.29 days). If you have questions, please
If you are still working on this, comment here to tell the bot to give you more time
The only thing left with this is the OtherDuties controller. Even though this feature might be going away? (#4242) I'll try to get this piece finished soon.
This issue has been inactive for 297 hours (12.38 days) and will be unassigned after 63 more hours (2.63 days). If you have questions, please
If you are still working on this, comment here to tell the bot to give you more time
This issue has been inactive for 369 hours (15.38 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.