casa icon indicating copy to clipboard operation
casa copied to clipboard

Add order by quantity, functionality in Supervisor index page

Open mauricio-prl opened this issue 3 years ago • 6 comments

Description We are adding the SupervisorDatatable service, in this PR, then we need to provide the functionality of order by:

  • Volunteer Assignments
  • Serving Transition Aged Youth
  • No Attempt (14 days)

Existing file(s) needing changing

When the PR is merged, they should be: app/datatables/supervisor_datatable.rb, spec/datatables/supervisor_datatable_spec.rb, spec/system/supervisors/index_spec.rb

mauricio-prl avatar Oct 02 '21 12:10 mauricio-prl

Hi, I can work on this but I suppose I need to wait for your PR to be merged?

matisnape avatar Oct 16 '21 21:10 matisnape

I think you can start if you copy some files, then after my pr is merged, you can adjust your branch. Thanks for helping! :D

mauricio-prl avatar Oct 17 '21 00:10 mauricio-prl

Hmm, I'm looking at how it works now and it seems that the sorting works already. What exactly is needed here? Is it about the query here? https://github.com/rubyforgood/casa/pull/2652/files#diff-22e57f3f06a75406351fecad9f5a40b186664a378509b34f4c59aed4d8946ff3R45 Not sure what happens here, though...

matisnape avatar Oct 17 '21 16:10 matisnape

I am not clear on the changes being requested here. @CovenantHuman FYI

compwron avatar Oct 18 '21 05:10 compwron

This issue has been inactive for 258 hours (10.75 days) and will be automatically unassigned after 102 more hours (4.25 days).

github-actions[bot] avatar Oct 29 '21 00:10 github-actions[bot]

This issue has been inactive for 378 hours (15.75 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.

github-actions[bot] avatar Nov 03 '21 00:11 github-actions[bot]

Not needed. Our largest casa org only has 7 supervisors so there's no need for sorting

FireLemons avatar Mar 16 '23 01:03 FireLemons

I will update #4664 to remove the tests added for this functionality.

crespire avatar Mar 16 '23 01:03 crespire