Potentially refactor how file uploads are handled.

Open benreyn opened this issue 5 years ago • 2 comments

Currently we read file contents and save them on the contents column of the temporary_files table. This could be unsafe. Im not aware of any restrictions that we have in regards to file uploads, but it would probably be better to upload the file to S3 or something?

Sep 05 '20 15:09 benreyn

@benreyn I think this would be a good idea, and may have been part of the original plan to do this eventually.

Sep 06 '20 15:09 mdworken

Keep in mind, that #276 relies pretty heavily on the existing implementation. When and if we decide to tackle this, that code will need to be refactored.

Sep 06 '20 20:09 benreyn