ferrum icon indicating copy to clipboard operation
ferrum copied to clipboard

Add screencast functionality

Open bradleyscollins opened this issue 1 year ago • 1 comments

This pull request adds an API that exposes CDP's screencast capability.

See the following:

Note: At this time, the Chrome DevTools Protocol documentation still has screencast methods/types marked as "experimental."

bradleyscollins avatar Sep 20 '24 21:09 bradleyscollins

A number of the test failures are on account of a difference between expected vs. actual screenshot height.

We noticed that as of Chrome 128, the heights of our screenshot/screencast images were different from (less than) the height specified in the window_size option of the Browser constructor. We had to set the viewport size explicitly to get the expected screenshot height.

bradleyscollins avatar Sep 20 '24 22:09 bradleyscollins

@bradleyscollins could you please rebase on master? after that we can merge, should be fixed in there

route avatar Nov 20 '24 05:11 route

@route, I think I have rebased correctly (and fixed a brittle test). Just let me know if there's anything else you need me to do.

And thank you for your kind consideration of my pull request.

bradleyscollins avatar Nov 27 '24 18:11 bradleyscollins

Hello, is there anything I can do to help to get this merged? We would like to use the Screencast API for debugging flaky tests. Thanks!

vojtad avatar Feb 25 '25 08:02 vojtad

Thank you!

route avatar Mar 05 '25 07:03 route

Yes, indeed, my thanks to you as well!

bradleyscollins avatar Mar 05 '25 22:03 bradleyscollins