rdoc icon indicating copy to clipboard operation
rdoc copied to clipboard
verified publisher icon ruby

Add keydown event listener to focus on search field

Open gemmaro opened this issue 3 years ago • 0 comments

Pressing the shortcut key (/, as seen at Ruby on Rails API) to focus on the search form.

For the following reasons, it is in draft status at this time.

  • [x] ~~I have not been able to check how rake works with the changes (1).~~ It works as expected.
  • [ ] I haven't fully considered whether this is the right shortcut key.
  • [ ] I haven't been able to make sure that changes to JavaScript don't affect other places.

(1) When I try to install with bundle exec rake install, The following error occured. But I don't think this has much to do with the subject, so temporary commented out rubocop:auto_correct task in Rakefile.

$ bundle exec rake install --trace
** Invoke install (first_time)
** Invoke build (first_time)
** Invoke generate (first_time)
** Invoke lib/rdoc/rd/block_parser.rb (first_time, not_needed)
** Invoke lib/rdoc/rd/block_parser.ry (first_time, not_needed)
** Invoke lib/rdoc/rd/inline_parser.rb (first_time, not_needed)
** Invoke lib/rdoc/rd/inline_parser.ry (first_time, not_needed)
** Invoke lib/rdoc/markdown.rb (first_time, not_needed)
** Invoke lib/rdoc/markdown.kpeg (first_time, not_needed)
** Invoke lib/rdoc/markdown/literals.rb (first_time, not_needed)
** Invoke lib/rdoc/markdown/literals.kpeg (first_time, not_needed)
** Execute generate
** Invoke rubocop:auto_correct (first_time)
** Execute rubocop:auto_correct
rubocop:auto_correct task is deprecated; use rubocop:autocorrect task or rubocop:autocorrect_all task instead.
rake aborted!
NameError: undefined local variable or method `task_args' for #<RuboCop::RakeTask:0x0000000108afe660 @name=:rubocop, @verbose=true, @fail_on_error=true, @patterns=[], @requires=[], @options=[], @formatters=[]>

            yield(*[self, task_args].slice(0, task_block.arity)) if task_block
                          ^^^^^^^^^
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rubocop-1.36.0/lib/rubocop/rake_task.rb:82:in `block (3 levels) in setup_subtasks'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/file_utils_ext.rb:58:in `verbose'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rubocop-1.36.0/lib/rubocop/rake_task.rb:81:in `block (2 levels) in setup_subtasks'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:281:in `block in execute'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:281:in `each'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:281:in `execute'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:219:in `block in invoke_with_call_chain'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:199:in `synchronize'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:199:in `invoke_with_call_chain'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:243:in `block in invoke_prerequisites'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:241:in `each'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:241:in `invoke_prerequisites'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:218:in `block in invoke_with_call_chain'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:199:in `synchronize'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:199:in `invoke_with_call_chain'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:243:in `block in invoke_prerequisites'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:241:in `each'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:241:in `invoke_prerequisites'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:218:in `block in invoke_with_call_chain'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:199:in `synchronize'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:199:in `invoke_with_call_chain'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:188:in `invoke'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/application.rb:160:in `invoke_task'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/application.rb:116:in `block (2 levels) in top_level'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/application.rb:116:in `each'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/application.rb:116:in `block in top_level'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/application.rb:125:in `run_with_threads'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/application.rb:110:in `top_level'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/application.rb:83:in `block in run'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/application.rb:186:in `standard_exception_handling'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/application.rb:80:in `run'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
/Users/gemmaro/.rbenv/versions/3.1.2/bin/rake:25:in `load'
/Users/gemmaro/.rbenv/versions/3.1.2/bin/rake:25:in `<top (required)>'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.3.16/lib/bundler/cli/exec.rb:58:in `load'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.3.16/lib/bundler/cli/exec.rb:58:in `kernel_load'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.3.16/lib/bundler/cli/exec.rb:23:in `run'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.3.16/lib/bundler/cli.rb:479:in `exec'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.3.16/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.3.16/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.3.16/lib/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.3.16/lib/bundler/cli.rb:31:in `dispatch'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.3.16/lib/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.3.16/lib/bundler/cli.rb:25:in `start'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.3.16/exe/bundle:48:in `block in <top (required)>'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.3.16/lib/bundler/friendly_errors.rb:117:in `with_friendly_errors'
/Users/gemmaro/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.3.16/exe/bundle:36:in `<top (required)>'
/Users/gemmaro/.rbenv/versions/3.1.2/bin/bundle:25:in `load'
/Users/gemmaro/.rbenv/versions/3.1.2/bin/bundle:25:in `<main>'
Tasks: TOP => install => build => rubocop:auto_correct

gemmaro avatar Sep 24 '22 14:09 gemmaro