rbs icon indicating copy to clipboard operation
rbs copied to clipboard

Published 20 hours ago • verified publisher icon ruby

CI & Sider

Open marcandre opened this issue 5 years ago • 2 comments

Sider tests look nice, but the current codebase should pass its tests...

For example I modified a line containing arg0 and got an error because of that...

It seems to check only the diff, which seems like the wrong way to go.

I'm not sure how to have it urn on everything, let me know if you need help.

marcandre avatar Oct 19 '20 05:10 marcandre

I don't want to add a new line with arg0, while I don't want to fix all of the existing code. If you change an existing line and Sider says something, just ignore it. I can close the warning and merge the PR.

(Removing all of argN at once would be another option...)

soutaro avatar Oct 19 '20 10:10 soutaro

I don't want to add a new line with arg0

I agree with this

while I don't want to fix all of the existing code.

This is my point. I disagree with this. Why not fix all the existing code?

(Removing all of argN at once would be another option...)

Yes, and fixing anything else too.

marcandre avatar Oct 19 '20 11:10 marcandre