rbs icon indicating copy to clipboard operation
rbs copied to clipboard

Published 20 hours ago • verified publisher icon ruby

Improve core/stdlib signature coverage

Open soutaro opened this issue 5 years ago • 10 comments

We provide the signatures of a very limited number of standard library classes. We will really appreciate if you write the signature of other classes.

(Note that we are currently working for standard library signatures.)

soutaro avatar Apr 18 '19 02:04 soutaro

Sorbet already has type signatures for a lot of the stdlib, have you considered writing something to transform their files into ruby-signature-compatible files to automate this process?

https://github.com/sorbet/sorbet/tree/master/rbi/core

connorshea avatar Jun 30 '19 23:06 connorshea

Yes, it should be one of the best ways to improve the coverage. I haven't tried yet.

soutaro avatar Jul 01 '19 14:07 soutaro

I know this ended up partially happening in #23, do we have any way of tracking progress for stdlib coverage? Essentially code coverage for type signatures. :)

connorshea avatar Jan 02 '20 22:01 connorshea

I have a guide for contributions at https://github.com/ruby/ruby-signature/blob/master/docs/CONTRIBUTING.md . Could you check it? Tell me if you have any questions or feedback.

soutaro avatar Jan 08 '20 08:01 soutaro

For a lot of the libraries in the spreadsheet, we should be able to get the signatures from Sorbet e.g. for csv or benchmark.

connorshea avatar Jan 10 '20 19:01 connorshea

Yes, it should be a good option to start having an initial version. However, I believe we need to review and revise them ourselves anyway.

soutaro avatar Jan 12 '20 03:01 soutaro

Hey, is this issue still open? I would like to work on this issue.

gaurav2699 avatar Mar 05 '21 18:03 gaurav2699

Hi. It seems that @gaurav2699 's question hasn't been answered until now, so I'd like to make sure.

Is it correct that this issue is still active?

Also, have you already implemented the idea of importing the sorbet type definition file?

I'm hesitant to start a contribution because I personally can't read the status of this issue.

Thank you for your time.

snaka avatar Jan 22 '22 05:01 snaka

I' ve read the code and the PR, and it seems to be still open, so I'll try to help as much as I can. Thank you very much.

Also, have you already implemented the idea of importing the sorbet type definition file?

It seems to have been addressed in the following PR 👍

https://github.com/ruby/rbs/pull/24

snaka avatar Jan 25 '22 23:01 snaka

I thought it would be better to change the title of this issue to "core and standard library".

Reference : https://github.com/ruby/rbs/issues/876

snaka avatar Feb 06 '22 03:02 snaka