rake icon indicating copy to clipboard operation
rake copied to clipboard

Published 20 hours ago • verified publisher icon ruby

[Fixes #246] Don't run file tasks needlessly (2nd attempt)

Open grzuy opened this issue 7 years ago • 2 comments

Second attempt at fixing #246.

grzuy avatar Feb 22 '18 16:02 grzuy

I solved conflicts with master and updated this PR.

grzuy avatar Mar 27 '18 17:03 grzuy

Code Climate is showing an issue to fix, apparently because one of the lib/rake/task.rb method became "too large" because of a couple of lines added as part of this PR.

@rake-maintainers How do you handle these cases? Should I attempt to fix the issue as part of this PR? Or you handle those refactors as separate PRs? I checked Code Climate issue and I already had some ideas on how to refactor, but wanted to ask first given it might end up being not a simple refactor.

Thank you.

grzuy avatar Apr 04 '18 21:04 grzuy