Alias names are too permissive in SnakeYAML-Engine

[headius]

trafficstars

See original issue at jruby/jruby#8352.

The following YAML fails to parse in SnakeYAML-Engine, used by the JRuby Psych extension:

--- &1 !ruby/object:Set
hash:
  :one: true
  :two: true
  *1: true

This is due to a bug in SnakeYAML-Engine reported here: https://bitbucket.org/snakeyaml/snakeyaml-engine/issues/54/do-not-allow-colon-to-be-a-part-of-an

This will be fixed shortly in an upcoming release of SnakeYAML-Engine. Psych will need to be updated to the new version and released.

[perlpunk]

The proper fix is to add a space after the alias:

  *1 : true

It's valid to have a colon in anchor names (and yes, I agree that it should have been forbidden, but it isn't).

[headius]

@asomov This is the Psych bug for the recent alias issue in SnakeYAML. Let us know if that fix is coming soon. Thank you!

[asomov]

@headius finally: https://bitbucket.org/snakeyaml/snakeyaml-engine/issues/54/insert-a-trailing-space-when-an-alias-is-a

[headius]

@asomov Is that ready for testing on my end?

[asomov]

@headius you can try the latest 2.9-SNAPSHOT

https://oss.sonatype.org/content/repositories/snapshots/org/snakeyaml/snakeyaml-engine/2.9-SNAPSHOT/

[headius]

@asomov Success! Combining your snapshot jar with my other fix jruby/jruby#8394, I can run the example from jruby/jruby#8352.

[asomov]

@headius Great! Do you need an urgent release?

[headius]

@asomov I don't know how much of an issue this is for @mcorino.

Releasing for us would be the psych gem first and then adding that to the JRuby release, but with our next JRuby release a week away it's too close. So whenever you can release is fine for us, and I can update the gem the same day.

[mcorino]

@headius @asomov Fine by me.

[asomov]

@headius @mcorino please ping me in advance (a week) to release when you need it (I will wait for other possible changes)

[mcorino]

@asomov @headius The issue is currently not blocking for me (I would like it fixed) so any time you get to it is fine by me.

[headius]

@asomov I don't think we've had any other changes come in, but we'd like to get this resolved now. When could you put out a release?

[asomov]

@headius 2.9 (2025-01-15) released It may take some time to propagate the version https://central.sonatype.com/artifact/org.snakeyaml/snakeyaml-engine

[headius]

@asomov Thank you!

[headius]

@hsbt @tenderlove Is this case worth adding a test for?

[headius]

@hsbt @tenderlove Oh I also need a release 😀

I can do it if you prefer that.

[tenderlove]

@headius go ahead and ship it!

[headius]

Psych 5.2.3 has been released! Thanks for the help everyone!