prism icon indicating copy to clipboard operation
prism copied to clipboard

Import Sorbet parser tests

Open kddnewton opened this issue 2 years ago • 4 comments

kddnewton avatar Mar 23 '23 02:03 kddnewton

Thanks for this feature! I wanted to point that Sorbet parser tests are a subset of whitequark since they are imported as we do version bumps in case that context wasn't shared. Looks like the main difference is that yarp currently doesn't import assert_diagnoses tests so I'd expect adding support for that would be enough to effectively pull in all Sorbet parser tests.

KaanOzkan avatar Apr 21 '23 15:04 KaanOzkan

Hey @KaanOzkan - I thought I saw some tests in Sorbet for checking that it could recover from specific syntax errors. Do you know where that might be? I can't seem to find them for some reason.

kddnewton avatar May 30 '23 17:05 kddnewton

@kddnewton Yes those aren't imported so they live under a different folder.

KaanOzkan avatar May 30 '23 19:05 KaanOzkan

Ah-ha! Yeah these are the ones I want to import.

kddnewton avatar May 30 '23 19:05 kddnewton

Closing this now since Emily is working on porting sorbet to prism so this no longer makes a lot of sense.

kddnewton avatar Jul 25 '24 19:07 kddnewton