pp icon indicating copy to clipboard operation
pp copied to clipboard

CI is broken on ruby-head

Open eregon opened this issue 1 year ago • 0 comments

See https://github.com/ruby/pp/actions/runs/7489634039/job/20386628987

 ===============================================================================
Failure: test_lasgn_literal(PPTestModule::PPAbstractSyntaxTree)
/home/runner/work/pp/pp/test/test_pp.rb:235:in `test_lasgn_literal'
     232:     def test_lasgn_literal
     233:       ast = AST.parse("_=1")
     234:       expected = "(SCOPE@1:0-1:3 tbl: [:_] args: nil body: (LASGN@1:0-1:3 :_ (LIT@1:2-1:3 1)))"
  => 235:       assert_equal(expected, PP.singleline_pp(ast, ''.dup), ast)
     236:     end
     237:   end
     238: end
#<RubyVM::AbstractSyntaxTree::Node:0x00007f8b9029b4e0>
<"(SCOPE@1:0-1:3 tbl: [:_] args: nil body: (LASGN@1:0-1:3 :_ (LIT@1:2-1:3 1)))"> expected but was
<"(SCOPE@1:0-1:3 tbl: [:_] args: nil body: (LASGN@1:0-1:3 :_ (INTEGER@1:2-1:3 1)))">

diff:
? (SCOPE@1:0-1:3 tbl: [:_] args: nil body: (LASGN@1:0-1:3 :_ (LINTEGER@1:2-1:3 1)))
===============================================================================

Probably not ideal to depend on unstable/experimental RubyVM::AbstractSyntaxTree in pp's CI.

eregon avatar Jan 11 '24 16:01 eregon