openssl issues

Can we please cut a 3.3.0 release?

2

There are many interface fixes that forward to the underlying IO which I'd like to take advantage of.

ssl: do not enable OpenSSL::SSL::OP_ALL by default

Respect the SSL options set by default by `SSL_CTX()` or by the system-wide OpenSSL configuration file. `OpenSSL::SSL::SSLContext#initialize` currently adds `OpenSSL::SSL::OP_ALL` on top of the default SSL options. Let's stop doing...

rhenium

`SSLSocket#accept` is confusing.

5

I would like to propose that we rename `SSLSocket#accept` and `SSLSocket#accept_nonblock` to `SSLSocket#start` and `SSLSocket#start_nonblock`. There are two reasons: 1. It aligns better with `SSLServer#start_immediately`. In other words, `start_immediately` ->...

ioquatix

OpenSSL::ASN1.decode supports fractional times & time zones

1

Using ASN1_TIME_to_tm added in openssl 1.1.1 Closes https://github.com/ruby/openssl/issues/725

segiddins

Avoid mutating SSLContext in SSLServer.

1

I think that we shouldn't mutate the `SSLContext` in `SSLServer` and instead be more proactive about setting the right defaults. ``` | FrozenError: can't modify frozen OpenSSL::SSL::SSLContext: # | →...

ioquatix

Test fail with OpenSSL 3.3.0 and mingw

5

I found test fails with OpenSSL 3.3.0 on mingw environment https://github.com/ruby/ruby/actions/runs/8806703011/job/24172105094?pr=10610 ``` 2) Error: OpenSSL::TestASN1#test_generalizedtime: OpenSSL::ASN1::ASN1Error: generalizedtime is too short D:/a/ruby/ruby/src/test/openssl/test_asn1.rb:700:in `decode' D:/a/ruby/ruby/src/test/openssl/test_asn1.rb:700:in `decode_test' D:/a/ruby/ruby/src/test/openssl/test_asn1.rb:435:in `test_generalizedtime' 3) Error: OpenSSL::TestASN1#test_utctime: OpenSSL::ASN1::ASN1Error:...

hsbt