openssl icon indicating copy to clipboard operation
openssl copied to clipboard

Published 20 hours ago • verified publisher icon ruby

Sync extconf.rb with ruby/ruby

Open peterzhu2118 opened this issue 2 years ago • 4 comments

Adds commit ruby/ruby@6d8f396f37350b7aa9c85a097929f54a0939448b and ruby/ruby@c8b3bd45cc3cae93ae701333202416838ee6a00c.

peterzhu2118 avatar Jul 08 '22 13:07 peterzhu2118

This is kept un-backported intentionally, so that these warnings will be fixed.

nobu avatar Jul 08 '22 14:07 nobu

I changed my mind. It seems tough to “fix” warnings, until we drop the support for older OpenSSLs. However since the current way is too compiler dependent, how about this? https://github.com/nobu/openssl/tree/openssl3-warnings

nobu avatar Jul 09 '22 17:07 nobu

I think that looks good. But we should still sync the extconf.rb between the ruby/openssl and ruby/ruby right?

peterzhu2118 avatar Jul 09 '22 17:07 peterzhu2118

ruby/ruby@6d8f396 will be reverted and sync from here to ruby/ruby, in that case.

nobu avatar Jul 09 '22 22:07 nobu

What's the next action? I'm not sure we choose https://github.com/nobu/openssl/commit/ee5347a99cc6576474be606cc5ab2b15b44819cb instead of this pull-request.

hsbt avatar Nov 29 '22 02:11 hsbt

https://github.com/ruby/openssl/pull/576 is best way for this.

hsbt avatar Nov 29 '22 03:11 hsbt