net-http icon indicating copy to clipboard operation
net-http copied to clipboard
verified publisher icon ruby

Refactor Net::HTTP#connect

Open stanhu opened this issue 1 year ago • 4 comments

The method was getting large, and in preparation for #141, I thought it would be easier to break up the method into several other methods.

stanhu avatar Jan 10 '24 00:01 stanhu

https://github.com/ruby/net-http/pull/147/files seems to have a similar refactoring.

stanhu avatar Jan 10 '24 08:01 stanhu

@nurse What do you think about this change?

stanhu avatar Jan 11 '24 21:01 stanhu

@nurse Could you review this?

stanhu avatar May 24 '24 17:05 stanhu

@hsbt, @nurse do you have time to review this change? This is related to a DNS rebinding issue that we are experiencing on gitlab.com that we are working to resolve. :pray:

xlgmokha avatar May 27 '24 17:05 xlgmokha