iconv icon indicating copy to clipboard operation
iconv copied to clipboard

Add JRuby's iconv ext.

Open hsbt opened this issue 3 years ago • 1 comments

I picked https://github.com/ruby/iconv/pull/7 and fixed conflict.

hsbt avatar Dec 10 '21 09:12 hsbt

@headius I could compile lib/iconv/iconv_jruby.jar But https://github.com/ruby/iconv/pull/19/files#diff-2c91fc8457d0f1d323ce0701563dca186310712c52eb8c12998550c719e5538bR5 is not working yet.

NameError: missing class name (`org.jruby.ext.iconv.IConvLibrary')
                                                              method_missing at org/jruby/javasupport/JavaPackage.java:252
                                                                      <main> at /Users/hsbt/Documents/github.com/ruby/iconv/lib/iconv.rb:5
                                                                     require at org/jruby/RubyKernel.java:974
                                                                     require at /Users/hsbt/.local/share/rbenv/versions/jruby-9.2.20.1/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:83
                                                                      <main> at /Users/hsbt/Documents/github.com/ruby/iconv/test/utils.rb:1
                                                                     require at org/jruby/RubyKernel.java:974
                                                                     require at /Users/hsbt/.local/share/rbenv/versions/jruby-9.2.20.1/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:83
                                                                      <main> at /Users/hsbt/Documents/github.com/ruby/iconv/test/test_basic.rb:3
                                                                     require at org/jruby/RubyKernel.java:974
                                                                     require at /Users/hsbt/.local/share/rbenv/versions/jruby-9.2.20.1/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:83
  /Users/hsbt/.local/share/gem/gems/rake-13.0.6/lib/rake/rake_test_loader.rb at /Users/hsbt/.local/share/gem/gems/rake-13.0.6/lib/rake/rake_test_loader.rb:21
                                                                      select at org/jruby/RubyArray.java:2668
                                                                      <main> at /Users/hsbt/.local/share/gem/gems/rake-13.0.6/lib/rake/rake_test_loader.rb:6
rake aborted!

Can you look this?

hsbt avatar Dec 10 '21 09:12 hsbt

@headius /cc @enebo Do you still interested this integration?

hsbt avatar Oct 07 '22 10:10 hsbt

Well that is a good question. We are not sure how important this library is anymore. We have what we have, but do people still use iconv much?

On Fri, Oct 7, 2022, 11:29 Hiroshi SHIBATA @.***> wrote:

@headius https://github.com/headius /cc @enebo https://github.com/enebo Do you still interested this integration?

— Reply to this email directly, view it on GitHub https://github.com/ruby/iconv/pull/19#issuecomment-1271415441, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACPF4MNRUHXUIVJRDX6V3WB73QZANCNFSM5JYVKBNQ . You are receiving this because you were mentioned.Message ID: @.***>

headius avatar Oct 08 '22 18:10 headius

@hsbt Is iconv still being shipped with CRuby?

headius avatar Oct 13 '22 14:10 headius

@headius No. iconv is already extracted from CRuby. In Japan, mostly use-cases are enough with NKF conversion. But some of encoding or case need iconv.

I have no strong opinion about this integration. But If you hope to ship JRuby code with iconv gem, I support it.

hsbt avatar Oct 17 '22 05:10 hsbt

@hsbt I think at this point it is very low priority. I think we should close this and wait to see if someone eventually needs it.

Thank you for your help!

headius avatar Oct 17 '22 16:10 headius

I see. Thanks for your time.

hsbt avatar Oct 17 '22 23:10 hsbt