gem_rbs_collection icon indicating copy to clipboard operation
gem_rbs_collection copied to clipboard

activejob: Add types for ActiveJob::Logging

Open sanfrecce-osaka opened this issue 1 year ago • 1 comments

  • logger is defined using Class#cattr_accessor in activesupport with instance_reader/instance_writer/instance_accessor set to true.
    • The default for logger is ActiveSupport::TaggedLogging, but it is not necessarily an instance of ActiveSupport::TaggedLogging or an inheritor of ActiveSupport::TaggedLogging (e.g. lograge). Therefore, it is defined as untyped.
  • log_arguments is defined using Class#class_attribute in activesupport with instance_accessor set to false and instance_predicate set to true.

sanfrecce-osaka avatar Nov 25 '24 12:11 sanfrecce-osaka

@sanfrecce-osaka Thanks for your contribution!

Please follow the instructions below for each change. See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

activejob

You changed RBS files for an existing gem. You need to get approval from the reviewers of this gem.

@ksss, @tk0miya, please review this pull request. If this change is acceptable, please make a review comment including APPROVE from here. Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR. Just comment /merge to merge this PR.

github-actions[bot] avatar Nov 25 '24 12:11 github-actions[bot]